int question

[thavok]

So i'm trying to figure out why this isn't working correctly and i keep getting a passing argument 1 of setText error. if anyone could please look at it i'm sure its something stupid.

#import "Controller.h"

@implementation Controller

- (void)awakeFromNib
{
	srand ( time(NULL) );
	randomNum = rand() % 100;
	guessOutput.text = [NSString stringWithFormat:@"%i", randomNum];
	[userGuess becomeFirstResponder];
}

- (IBAction)guess:(id)sender;
{
	userGuess.text = num1;
	
	if (num1 = randomNum);
	{
		guessOutput.text = @"You Guessed Right";
	}
	
	if (num1 > randomNum);
	{
		guessOutput.text = @"Too Low";
	}
	
	if (num1 < randomNum);
	{
		guessOutput.text = @"Too High";
	}
	
	
}


@end

[smasher]

Is num1 an int? userGuess.text or [userGuess setText: ] expects a string, not an int. You'll have to use stringWithFormat like you did when setting the text of guessOutput.

[thavok]

Sorry I'm really new at this i tried

- (IBAction)guess:(id)sender;
{
	[NSstring stringWithFormat:@"%i", num1];
	
	if (num1 = randomNum);
	{
		guessOutput.text = @"You Guessed Right";
	}
	
	if (num1 > randomNum);
	{
		guessOutput.text = @"Too Low";
	}
	
	if (num1 < randomNum);
	{
		guessOutput.text = @"Too High";
	}
	
	
}

num1 is an int, i'm wondering if there is some way to do it without num1 like compare userGuess vs randomNum

[smasher]

Sorry, I thought you were trying to set userGuess.text . Are you trying to get the number from userGuess.text into num1? Then you want this:

num1 = [userGuess.text intValue];

Also, you want to use if (num1 == randomNum) , not if (num1 = randomNum) . using two == tests a value, using a single = changes a value.

[thavok]

So they syntax seems to be right now but it keeps reverting to the last if statement, the only reason I make it display the random number at first is so I know what the value is so I can test it, and no matter if I guess right on, to low or to high it tells me to high.

and thank you so much for your help I was stumbling through this all day yesterday to get frustrated by the int value vs the string. he is what i have so far.

Also I just added a guessCount so it could count how many tries it takes by setting it to 0 in the awake from nib and then adding one to the int value everytime they hit the guess button. how would i get that to display with a string the you guessed right statement

#import "Controller.h"

@implementation Controller

- (void)awakeFromNib
{
	srand ( time(NULL) );
	randomNum = rand() % 100;
	// This line will be taken out when I know my if statements work properly
        guessOutput.text = [NSString stringWithFormat:@"%i", randomNum];
	
        [userGuess becomeFirstResponder];
	guessCount = 0;
}

- (IBAction)guess:(id)sender;
{
	num1 = [userGuess.text intValue];
	guessCount = guessCount + 1;
	
	if (num1 == randomNum);
	{
		// I want to add the guess count after your guessed right
		guessOutput.text = @"You Guessed Right";
		
	}
	
	if (num1 > randomNum);
	{
		guessOutput.text = @"Too Low";
	}
	
	if (num1 < randomNum);
	{
		guessOutput.text = @"Too High";
	}
	
	
}


@end

[Mr Jack]

You've got semicolons after your if statements, they shouldn't be there. What's happening is that each of your if statements is controlling an empty statement created by that stray semicolon rather than the compound statement in braces you want it to control.

[thavok]

Stray ; it works!!! thanks you guys for all your info, sorry for all the silly questions.

as far as the guess count goes I though something like this might work but it doesn't do i need to create another label to display the counter.

	if (num1 == randomNum)
	{
		guessOutput.text = @"You Guessed Right", @",%i", guessCount;
	}

and one last question if i add a reset button do I just create an action to reset and pick a new random number like

- (IBAction)resetid)sender;
// guess count to zero and pick new random number?

ps thanks for all the help so far guys just bought some new apps to try out :-)

[Mr Jack]

Originally Posted by thavok

as far as the guess count goes I though something like this might work but it doesn't do i need to create another label to display the counter.

I think you want to use stringWithFormat, like this:

if (num1 == randomNum)
	{
		guessOutput.text = [NSString stringWithFormat: @"You Guessed Right %d", guessCount];
	}

and one last question if i add a reset button do I just create an action to reset and pick a new random number like

That sounds about right, yeah.

[thavok]

Thank you again it works like a charm, sorry this is my first solo app, i've been going through some books but with only a background in assembly and basic objective c is taking a bit to learn.