removing objects in view in an array

[Mjsdabeast]

Hi, I am trying to get this game to work, but it gets messed up heres the code:

-(void)moveMeteors{
	
	for (int i = [bigbombArray count] - 1; i >=0; i--){
		UIView *bigbomb = [bigbombArray objectAtIndex:i];
		
		CGPoint newCenter = bigbomb.center;
		newCenter.y = newCenter.y +5;
		bigbomb.center = newCenter;
	
		if (bigbomb.frame.origin.y > 390){ // if off the bottom
			self.view = gameOver;
			[timer1 invalidate];
			timer1 = nil;
			score = 0;
			
			newCenter.y = newCenter.y - 5;
			[bigbomb removeFromSuperview];
			
			[bigbombArray removeObjectAtIndex:i];
			
			
			continue;
		}

Ok so everything works for moving the images in the array but when one of them hits the bottom and goes to the game over screen, if you play again the other images that didn't hit the bottom are still there and you almost immediately lose. Then if you go to even the next level after one touching the bottom it makes about 100 images when i don't want it to.

[Mjsdabeast]

Originally Posted by Mjsdabeast

Hi, I am trying to get this game to work, but it gets messed up heres the code:

-(void)moveMeteors{
	
	for (int i = [bigbombArray count] - 1; i >=0; i--){
		UIView *bigbomb = [bigbombArray objectAtIndex:i];
		
		CGPoint newCenter = bigbomb.center;
		newCenter.y = newCenter.y +5;
		bigbomb.center = newCenter;
	
		if (bigbomb.frame.origin.y > 390){ // if off the bottom
			self.view = gameOver;
			[timer1 invalidate];
			timer1 = nil;
			score = 0;
			
			newCenter.y = newCenter.y - 5;
			[bigbomb removeFromSuperview];
			
			[bigbombArray removeObjectAtIndex:i];
			
			
			continue;
		}

Ok so everything works for moving the images in the array but when one of them hits the bottom and goes to the game over screen, if you play again the other images that didn't hit the bottom are still there and you almost immediately lose. Then if you go to even the next level after one touching the bottom it makes about 100 images when i don't want it to.

Does anyone know?

[smasher]

Sounds like the bug is in your "game over" code. You need to remove all of the bombs from the array an the screen; it looks like you just remove one bomb now.

I'd move all of the gameOver stuff to another method for clarity's sake, and do this:

if (bigbomb.frame.origin.y > 390){ // if off the bottom
	[self gameOver];
	break; //note break, not continue!
	}

I changed the "continue" to a "break" because you don't want to keep checking the other bombs if the game is over. A "continue" skips to the next cycle of the loop, but "break" will break you out of the loop entirely.

Now in gameOver you can loop through the array and remove all the bombs from the screen and array.

[Mjsdabeast]

Originally Posted by smasher

Sounds like the bug is in your "game over" code. You need to remove all of the bombs from the array an the screen; it looks like you just remove one bomb now.

I'd move all of the gameOver stuff to another method for clarity's sake, and do this:

if (bigbomb.frame.origin.y > 390){ // if off the bottom
	[self gameOver];
	break; //note break, not continue!
	}

I changed the "continue" to a "break" because you don't want to keep checking the other bombs if the game is over. A "continue" skips to the next cycle of the loop, but "break" will break you out of the loop entirely.

Now in gameOver you can loop through the array and remove all the bombs from the screen and array.

Thank you, but the one main problem is I don't know exactly how to loop through the array and remove the images from the screen. I have tried: bigbombArray = nil; but it doesn't work
[bigbombArray removeObjectsAtIndexes:i]; (didn't really think it would work)

[Applesson]

in your game over code:

// loop through all entries in the array and remove them
for (UIView *bomb in bigbombArray)
 [bomb removeFromSuperview];

// remove all objects from the array
[bigbombArray removeAllObjects];

[Mjsdabeast]

Originally Posted by Applesson

in your game over code:

// loop through all entries in the array and remove them
for (UIView *bomb in bigbombArray)
 [bomb removeFromSuperview];

// remove all objects from the array
[bigbombArray removeAllObjects];

ok I put this code and fixed it(it's bigbomb not bomb). But when one of the images hits the bottom it crashes and the debugger says it's because of

[self removeimages];
and
for (UIView *bigbomb in bigbombArray)

[TapTouchClick]

sigh. no, its *bomb. you dont want to name it something already declared...

[Mjsdabeast]

Originally Posted by TapTouchClick

sigh. no, its *bomb. you dont want to name it something already declared...

ok my bad, but it still crashes and it's saying it's because of the [self removeimages]; and for (UIView *bomb in bigbombArray)

[Tinyted]

I recall doing such a thing with my test app. I had several balls falling down, and it would explode after a certain situation(which isn't the point)
When the user has filled the entire screen with balls or failed. I clear out the ballarrays

Here's the code that removes the array. BallArray contains UIViews.

for (int a=0; a<[BallArray count]; a++)
		{
			NSString *testtext2 = [[NSString alloc] initWithFormat:@"Failed~"];
			test2.text=testtext2;
			score=0;
			[[BallArray objectAtIndex:a] removeFromSuperview];
			[BallArray removeObjectAtIndex:a];
			a--;
				
		}

You have to do a loop because each UIView needs to remove from super view first.
By the way I don't think.

for (UIView *bomb in bigbombArray)
 [bomb removeFromSuperview];

Is a legit statement.
Another method not sure if it saves a bit of time is this.

for (int a=0; a<[BallArray count]; a++)
		{
			NSString *testtext2 = [[NSString alloc] initWithFormat:@"Failed~"];
			test2.text=testtext2;
			score=0;
			[[BallArray objectAtIndex:a] removeFromSuperview];			
			a--;				
		}[BallArray removeAllOBjects];

Just remember to replace BallArray with your array.
And just in case this info is needed, my BallArray is an NSMutableArray

[Mjsdabeast]

Originally Posted by Tinyted

I recall doing such a thing with my test app. I had several balls falling down, and it would explode after a certain situation(which isn't the point)
When the user has filled the entire screen with balls or failed. I clear out the ballarrays

Here's the code that removes the array. BallArray contains UIViews.

for (int a=0; a<[BallArray count]; a++)
		{
			NSString *testtext2 = [[NSString alloc] initWithFormat:@"Failed~"];
			test2.text=testtext2;
			score=0;
			[[BallArray objectAtIndex:a] removeFromSuperview];
			[BallArray removeObjectAtIndex:a];
			a--;
				
		}

You have to do a loop because each UIView needs to remove from super view first.
By the way I don't think.

for (UIView *bomb in bigbombArray)
 [bomb removeFromSuperview];

Is a legit statement.
Another method not sure if it saves a bit of time is this.

for (int a=0; a<[BallArray count]; a++)
		{
			NSString *testtext2 = [[NSString alloc] initWithFormat:@"Failed~"];
			test2.text=testtext2;
			score=0;
			[[BallArray objectAtIndex:a] removeFromSuperview];			
			a--;				
		}[BallArray removeAllOBjects];

Just remember to replace BallArray with your array.
And just in case this info is needed, my BallArray is an NSMutableArray

Ok, finally it works. I used the code that you put but in a couple different places and also I had to set the array to nil and it's working perfectly now. Thank you so much. Here is the working code:

-(void)createmissiles{
	
    if (bigbombArray==nil){
		bigbombArray = [[NSMutableArray alloc] init];
    }
	
    UIImage *bigbombImage = [UIImage imageNamed:@"bigbomb.png"];
    
	
    for (int i = 0; i< 30; i++){  
        bigbomb = [[UIImageView alloc] initWithImage:bigbombImage];
		
	
        int x = arc4random()%320; 
		int y = -70;
        y = y - arc4random()%500; 
        bigbomb.center = CGPointMake(x,y);
		
        [self.view addSubview:bigbomb]; 
        [bigbombArray addObject:bigbomb]; 
       [bigbomb release];
    }
	
}	
-(void)moveMeteors{
	
	for (int i = [bigbombArray count] - 1; i >=0; i--){
		UIView *bigbomb = [bigbombArray objectAtIndex:i];
		
		CGPoint newCenter = bigbomb.center;
		newCenter.y = newCenter.y +5;
		bigbomb.center = newCenter;
	
		if (bigbomb.frame.origin.y > 390){ // if off the bottom
			
			self.view = gameOver;
			[timer1 invalidate];
			timer1 = nil;
			score = 0;
			
			newCenter.y = newCenter.y - 5;

			[self performSelector:@selector(removeimages)];
			[[bigbombArray objectAtIndex:i] removeFromSuperview];
			[bigbombArray removeObjectAtIndex:i];
			break;
		}
}
-(void)removeimages {
	for (UIView *bomb in bigbombArray) {
		[bomb removeFromSuperview];
                 bigbombArray = nil;
	
	}
	
}