Delegate confusion...

[nick.keroulis]

The error:

Existing ivar 'delegate' for unsafe_unretained property 'delegate' must be_unsafe_unretained

The code:

@interface HRColorPickerViewController : UIViewController
{
    id<HRColorPickerViewControllerDelegate> delegate;
    HRColorPickerView* colorPickerView;
    
    UIColor *_color;
    BOOL _fullColor;
    HCPCSaveStyle _saveStyle;
}

@property (assign, nonatomic) id<HRColorPickerViewControllerDelegate> delegate;
...
@end

@implementation HRColorPickerViewController

@synthesize delegate;
...
@end

It seems i can't find any errors.

[Duncan C]

Originally Posted by nick.keroulis

The error:

Existing ivar 'delegate' for unsafe_unretained property 'delegate' must be_unsafe_unretained

The code:

@interface HRColorPickerViewController : UIViewController
{
    id<HRColorPickerViewControllerDelegate> delegate;
    HRColorPickerView* colorPickerView;
    
    UIColor *_color;
    BOOL _fullColor;
    HCPCSaveStyle _saveStyle;
}

@property (assign, nonatomic) id<HRColorPickerViewControllerDelegate> delegate;
...
@end

@implementation HRColorPickerViewController

@synthesize delegate;
...
@end

It seems i can't find any errors.

You are tripping the peculiarities of ARC.

Properties that are declared as assign are not tracked by ARC. For properties, you use the settings strong, weak, and assign. These equate to __strong, __weak, and __unsafe_unretained for instance variables.

Here is a table of the way you declare properties, and the way you need to declare their instance variables to match

Property declaration............iVar declaration
strong...............................__strong
weak................................__weak
assign ..............................__unsafe_unretained


so, change the declaration of your delegate iVar to look like this:

    __unsafe_unretained id<HRColorPickerViewControllerDelegate> delegate;

[nick.keroulis]

@property (assign, nonatomic) __unsafe_unretained id<HRColorPickerViewControllerDelegate> delegate;

Tried that and it still doesn't work...

[ebender001]

Originally Posted by nick.keroulis

@property (assign, nonatomic) __unsafe_unretained id<HRColorPickerViewControllerDelegate> delegate;

Tried that and it still doesn't work...

That's not what he recommended. Not the property, the ivar.

@interface HRColorPickerViewController : UIViewController
{
    __unsafe_unretained id<HRColorPickerViewControllerDelegate> delegate;
    HRColorPickerView* colorPickerView;
    
    UIColor *_color;
    BOOL _fullColor;
    HCPCSaveStyle _saveStyle;
}

Why use an ivar, anyway?
Why not just use the recommended property declaration:

@property (nonatomic, weak) id <HRColorPickerViewControllerDelegate> delegate;

Ed

[nick.keroulis]

Originally Posted by ebender001

That's not what he recommended. Not the property, the ivar.

@interface HRColorPickerViewController : UIViewController
{
    __unsafe_unretained id<HRColorPickerViewControllerDelegate> delegate;
    HRColorPickerView* colorPickerView;
    
    UIColor *_color;
    BOOL _fullColor;
    HCPCSaveStyle _saveStyle;
}

Why use an ivar, anyway?
Why not just use the recommended property declaration:

@property (nonatomic, weak) id <HRColorPickerViewControllerDelegate> delegate;

Ed

Dunno, not my code...