NSXMLParser to NSMutableArray

[r@t]

Hi, I can't seem to get this single array to save into another object's NSMutableArray. I can't even get a count from "mArray". Ideas to a solution would be appreciated. I have looked on previous threads but still can't see what i am doing wrong. Thanks

- (void)parser:(NSXMLParser *)parser foundCharacters:(NSString *)string
{
    [nodeContent appendString:[string stringByTrimmingCharactersInSet:[NSCharacterSet whitespaceAndNewlineCharacterSet]]];
}

- (void)parser:(NSXMLParser *)parser didStartElement:(NSString *)elementName namespaceURI:(NSString *)namespaceURI qualifiedName:(NSString *)qName attributes:(NSDictionary *)attributeDict{			
    //NSLog(@"found this element: %@", elementName);
	currentElement = [elementName copy];
    
	if ([elementName isEqualToString:@"z:row"]) {
        
        currentTitle=[[NSMutableString alloc]init];
        currentTitle =[attributeDict valueForKey:@"ows_Title"]; 
        
        NSLog(@"title:%@",currentTitle);
    }
}   

- (void)parser:(NSXMLParser *)parser didEndElement:(NSString *)elementName namespaceURI:(NSString *)namespaceURI qualifiedName:(NSString *)qName{

	//NSLog(@"ended element: %@", elementName);
	if ([elementName isEqualToString:@"z:row"]) {
        
        [mArray addObject:currentTitle];
              
    }
}

- (void)parserDidEndDocument:(NSXMLParser *)parser {
	
	//[activityIndicator stopAnimating];
	//[activityIndicator removeFromSuperview];
    
    NSMutableArray *tempDepartments = [[NSMutableArray alloc] initWithArray:mArray];
    accountData.departments = tempDepartments;
    [tempDepartments release];
	
	NSLog(@"parse complete");
    NSLog(@"accountData.departments: %d", [accountData.departments count]);
    
}


- (void)dealloc {
    
    [convertToStringData release];
    [accountData release];
    [mArray release];
    [super dealloc];
}

@end

the log is as follows:


</listitems></GetListItemsResult></GetListItemsResponse></soap:Body></soap:Envelope>
2011-11-21 15:33:03.309 ProjectTM[28209:f803] title:All Departments
2011-11-21 15:33:03.309 ProjectTM[28209:f803] title:Eng
2011-11-21 15:33:03.312 ProjectTM[28209:f803] titleeck
2011-11-21 15:33:03.314 ProjectTM[28209:f803] title:Interior
2011-11-21 15:33:03.316 ProjectTM[28209:f803] title:Bridge
2011-11-21 15:33:03.317 ProjectTM[28209:f803] parse complete
2011-11-21 15:33:03.318 ProjectTM[28209:f803] accountData.departments: 0

[baja_yu]

Are you sure your 'mArray' contains anything? Where and how is it declared? Put a breakpoint on 'mArray addObject' call in parser:didEndElement to see if anything is actually added to it.

[ebender001]

Originally Posted by baja_yu

Are you sure your 'mArray' contains anything? Where and how is it declared? Put a breakpoint on 'mArray addObject' call in parser:didEndElement to see if anything is actually added to it.

Usual problem is failure to instantiate your mutable array, therefore sending messages to nil.

Ed

[r@t]

Originally Posted by baja_yu

Are you sure your 'mArray' contains anything? Where and how is it declared? Put a breakpoint on 'mArray addObject' call in parser:didEndElement to see if anything is actually added to it.

Thanks for lightening response ... mArray is @synthesized ... judging by my new NSLogs nothing is going in to mArray:

- (void)parser:(NSXMLParser *)parser didEndElement:(NSString *)elementName namespaceURI:(NSString *)namespaceURI qualifiedName:(NSString *)qName{
    
        //NSLog(@"ended element: %@", elementName);
	if ([elementName isEqualToString:@"z:row"]) {
        
        [mArray addObject:currentTitle];
         NSLog(@"mArray:%d",[mArray count]);     
    }
    
}

- (void)parserDidEndDocument:(NSXMLParser *)parser {
	
	//[activityIndicator stopAnimating];
	//[activityIndicator removeFromSuperview];
    
    NSMutableArray *tempDepartments = [[NSMutableArray alloc] initWithArray:mArray];
    accountData.departments = tempDepartments;
    [tempDepartments release];
	
	NSLog(@"parse complete");
    NSLog(@"mArray total:%d",[mArray count]);
    NSLog(@"accountData.departments: %d", [accountData.departments count]);
    
}

</listitems></GetListItemsResult></GetListItemsResponse></soap:Body></soap:Envelope>
2011-11-21 16:41:03.099 ProjectTM[28613:f803] title:All Departments
2011-11-21 16:41:03.100 ProjectTM[28613:f803] mArray:0
2011-11-21 16:41:03.101 ProjectTM[28613:f803] title:Eng
2011-11-21 16:41:03.102 ProjectTM[28613:f803] mArray:0
2011-11-21 16:41:03.102 ProjectTM[28613:f803] titleeck
2011-11-21 16:41:03.145 ProjectTM[28613:f803] mArray:0
2011-11-21 16:41:03.145 ProjectTM[28613:f803] title:Interior
2011-11-21 16:41:03.145 ProjectTM[28613:f803] mArray:0
2011-11-21 16:41:03.146 ProjectTM[28613:f803] title:Bridge
2011-11-21 16:41:03.146 ProjectTM[28613:f803] mArray:0
2011-11-21 16:41:03.167 ProjectTM[28613:f803] parse complete
2011-11-21 16:41:03.168 ProjectTM[28613:f803] mArray total:0
2011-11-21 16:41:03.169 ProjectTM[28613:f803] accountData.departments: 0

[baja_yu]

It's not enough to just @synthesize. That only creates getter and/or setter methods. The object still needs to be alloc/init-ed.

[r@t]

Originally Posted by baja_yu

It's not enough to just @synthesize. That only creates getter and/or setter methods. The object still needs to be alloc/init-ed.

Thanks baja_yu...

[r@t]

Originally Posted by r@t

Thanks baja_yu... Is "mArray = [[NSMutableArray alloc]initWithObjects:currentTitle, nil]; " correct? If so where should i put it to stop it overwriting itself?

Thank you for your help .. all is good

[baja_yu]

That's right. Just remember that if an array was previously set to myArray, you need to release it before allocing a new one, and you need to release it in dealloc as well. As for where to create the array, it depends on how you want your parser to work, do you want to keep adding to the array with each parse, in which case you would just create the array once (viewDidLoad or similar), but if you want the array to hold just the items from the last parse, you would create the array (or at least empty the current one) each time before you start parsing.