Potential Leak of an Object

[aceiswild]

Hey guys, i am getting a Potential Leak of an Object Allocated in the given code below. I am assuming i am not releasing something somewhere. There are no other leaks in my project besides this one. Do i need to declare something in my .M class?


AppDelegate .M:

 
#import "SliderPuzzleAppDelegate.h"
#import "SliderController.h"


@implementation SliderPuzzleDemoAppDelegate

@synthesize window;
@synthesize sliderController;
@synthesize vc;

- (void)applicationDidFinishLaunching:(UIApplication *)application {   

    self.sliderController = [[SliderController alloc] init];
    [window addSubview:sliderController.view];  <----- Potential Leak
    [window makeKeyAndVisible];

}

- (void)dealloc {
    [sliderController release];
    [window release];
    [super dealloc];

}


@end

[baja_yu]

Same as in your other thread, this

self.sliderController = [[SliderController alloc] init];

is a leak. I strongly suggest you read Brian's guide to properties here: http://www.iphonedevsdk.com/forum/ip...roperties.html

[SundialSoft]

Originally Posted by aceiswild

Hey guys, i am getting a Potential Leak of an Object Allocated in the given code below. I am assuming i am not releasing something somewhere. There are no other leaks in my project besides this one. Do i need to declare something in my .M class?


AppDelegate .M:

 
#import "SliderPuzzleAppDelegate.h"
#import "SliderController.h"


@implementation SliderPuzzleDemoAppDelegate

@synthesize window;
@synthesize sliderController;
@synthesize vc;

- (void)applicationDidFinishLaunching:(UIApplication *)application {   

    self.sliderController = [[SliderController alloc] init];
    [window addSubview:sliderController.view];  <----- Potential Leak
    [window makeKeyAndVisible];

}

- (void)dealloc {
    [sliderController release];
    [window release];
    [super dealloc];

}


@end

Have you considered ARC. If it's not a huge project it will convert easily & then it's bye bye retain release blues for ever. My 2nd app was written much faster than the first due to ARC. Testing time goes down as well.

[Duncan C]

Originally Posted by SundialSoft

Have you considered ARC. If it's not a huge project it will convert easily & then it's bye bye retain release blues for ever. My 2nd app was written much faster than the first due to ARC. Testing time goes down as well.

Except that even with ARC, you need to understand the rules of memory management. ARC means you have less places to screw up, but if you don't understand when to declare things as strong, and when to use weak, and when you need to nil out pointers, you will still have problems.

[ebender001]

Originally Posted by Duncan C

Except that even with ARC, you need to understand the rules of memory management. ARC means you have less places to screw up, but if you don't understand when to declare things as strong, and when to use weak, and when you need to nil out pointers, you will still have problems.

I can't believe that all of the responders are such CONTROLLERS and won't let this guy SLIDE so that he can be RELEASED from his misery!

Ed

[aceiswild]

Originally Posted by ebender001

I can't believe that all of the responders are such CONTROLLERS and won't let this guy SLIDE so that he can be RELEASED from his misery!

Ed

Haha I like that one. I actually can slide my pieces around. Rigt now I'm just doing some extreme cleaning of my code because I had a rough copy and good copy so I'm just fixing some things!

Steve