NSMutableArray objects are "out of scope"

[JheeBz]

Hello,

I've been having this issue for the entirety of the past week and I cannot seem to fix the issue. I am trying to initialise the member variable "drinks" with a series of objects but when I do that, each object in the array shows up as "out of scope". I have tried creating a fresh new array which fills up fine, but then if I try to copy it over to my "drinks" array the objects just show up as "out of scope" again. Alternatively I have tried to fill up the "drinks" array with just strings and that doesn't work either.

Here is my .h file:

#import <UIKit/UIKit.h>

@interface SecondViewController : UIViewController <UITableViewDelegate,UITableViewDataSource>
{
            
        UITableView *PrefsTable;
        NSMutableArray *favourites;
        NSMutableArray *drinks;
        int checkCounter;
}

@property (nonatomic, retain) IBOutlet UITableView *PrefsTable;
@property (nonatomic, retain) NSMutableArray *drinks;
@property (nonatomic, retain) NSMutableArray *favourites;

- (void) addDrink: (NSString *) name;

@end

Here is the ViewDidLoad method in the .m file:

- (void)viewDidLoad
{
    [super viewDidLoad];
    checkCounter = 0;
    Drink *drink1 = [[[Drink alloc] initWithImage:nil name:@"Test1" caffeine:11] autorelease];
    Drink *drink2 = [[[Drink alloc] initWithImage:nil name:@"Test2" caffeine:22] autorelease];
    Drink *drink3 = [[[Drink alloc] initWithImage:nil name:@"Test3" caffeine:33] autorelease];
    Drink *drink4 = [[[Drink alloc] initWithImage:nil name:@"Test4" caffeine:44] autorelease];
    Drink *drink5 = [[[Drink alloc] initWithImage:nil name:@"Test5" caffeine:55] autorelease];
    self.drinks = [[NSMutableArray alloc] initWithObjects: drink1, drink2, drink3, drink4, drink5, nil];
}

Here is an image of the error I was getting:
Error image

Each of the objects initialise properly, but they don't get put in the array properly. I really do not know why this is, can anybody please help me?

Thanks in advance,
JheeBz

[Domele]

Do you have an actual problem inside your code or is the debugger just not showing your objects correctly? If you have an actual problem in your code, how did you come to this conclusion?

[JheeBz]

Originally Posted by Domele

Do you have an actual problem inside your code or is the debugger just not showing your objects correctly? If you have an actual problem in your code, how did you come to this conclusion?

I do have a problem, the problem is that each object contained within the array is empty or "out of scope", whatever that means. I need those objects in that array.

[Domele]

Yes, are you just going by the debugger or have you actually tried doing something with those objects and gotten an error or crash?

[JheeBz]

Originally Posted by Domele

Yes, are you just going by the debugger or have you actually tried doing something with those objects and gotten an error or crash?

Yes, I try to retrieve these in another method and they don't show up.

[Domele]

Post the code and btw, you are going to leak your drinks array but we'll fix that later when we've solved your problem.

[JheeBz]

Originally Posted by Domele

Post the code and btw, you are going to leak your drinks array but we'll fix that later when we've solved your problem.

This is what ViewDidDisappear looks like at the moment:

- (void)viewDidDisappear:(BOOL)animated
{
        for (int i = 0; i < [drinks count]; i++)
        {
                Drink *drink  = [drinks objectAtIndex:i];
                NSLog(@"%@", [drink name]);
        }
        NSLog(@"FAVOURITES COUNT: %d", [drinks count]);
        NSLog(@"VIEW DISAPPEARED");
}

The output of this is:

2011-09-17 17:04:04.710 Project[1335:207] FAVOURITES COUNT: 5
2011-09-17 17:04:04.711 Project[1335:207] VIEW DISAPPEARED

[Domele]

Edit: I'm sorry, I learned this from an old text. You don't need to declare the variable outside.

Edit2: You do need to declare it outside if you have c89. So just to be safe, declare your i variable outside and see what happens.

int i = 0;
for (i = 0; i < [drinks count]; i++)
        {
                Drink *drink  = [drinks objectAtIndex:i];
                NSLog(@"%@", [drink name]);
        }

[JheeBz]

Originally Posted by Domele

Edit: I'm sorry, I learned this from an old text. You don't need to declare the variable outside.

Edit2: You do need to declare it outside if you have c89. So just to be safe, declare your i variable outside and see what happens.

int i = 0;
for (i = 0; i < [drinks count]; i++)
        {
                Drink *drink  = [drinks objectAtIndex:i];
                NSLog(@"%@", [drink name]);
        }

Wow that works! I had no idea you had to do this, I thought that was only necessary for while loops.

Thank you so very much, you just saved me another week of staring at the same problem.

[Domele]

Okay now about your drinks array leaking, you have a couple options.

1. You could just not use the property to alloc and init your array.

array = [[NSArray alloc] initWithObjects:@"blah, @"blah"];

2. You could add an auto release to the end of your call.

self.array = [[[NSArray alloc] initWithObjects:@"blah, @"blah"] autorelease];

3. You use the 3 line format, create a temporary array with your objects, use the temp array to assign your property, and then release the temp array.

NSArray *tempArray = [NSArray alloc] initWithObjects:@"blah, @"blah"];
self.array = tempArray;
[tempArray release];

[JheeBz]

Originally Posted by Domele

Okay now about your drinks array leaking, you have a couple options.

1. You could just not use the property to alloc and init your array.

array = [[NSArray alloc] initWithObjects:@"blah, @"blah"];

2. You could add an auto release to the end of your call.

self.array = [[[NSArray alloc] initWithObjects:@"blah, @"blah"] autorelease];

3. You use the 3 line format, create a temporary array with your objects, use the temp array to assign your property, and then release the temp array.

NSArray *tempArray = [NSArray alloc] initWithObjects:@"blah, @"blah"];
self.array = tempArray;
[tempArray release];

Thanks for that. I added an autorelease to the end of the assignment. I originally had that but I've been fiddling around so much that I must've forgotten.