ShareKit Warnings

[Objective Zero]

I am getting the following 3 warnings in these pictures from ShareKit:
1.

2.

3.


I have googled these warnings but have found nothing.
Does anyone know how to fix these warnings?

Thanks!

[MatthewD]

1 & 2: You are passing a class. You need to pass an instance of the class that adopts the protocols.
3: You need to cast.

[Objective Zero]

Originally Posted by MatthewD

1 & 2: You are passing a class. You need to pass an instance of the class that adopts the protocols.
3: You need to cast.

I fixed #1 with making the delegate: as

2. I tried doing something similar that I did with #1 but for #2 but it didn't work. Any thoughts?

3. What do I need to cast?

[harrytheshark]

1 / 2. You need to assign an instance of an object as the delegate, not a class.

3. You need to cast [aResponse retain];

[Objective Zero]

So for #2, I am confused why this would not work:

+ (void)logout
{
	FBSession *fbSession; 
	
	if(!SHKFacebookUseSessionProxy){
		fbSession = [FBSession sessionForApplication:SHKFacebookKey
												 secret:SHKFacebookSecret
											   delegate:fbSession];
		
	}else {
		fbSession = [FBSession sessionForApplication:SHKFacebookKey
										getSessionProxy:SHKFacebookSessionProxyURL
											   delegate:fbSession];
	}

	[fbSession logout];
}

[harrytheshark]

You're making it its own delegate. Is this your intention?

What do you mean when you say it doesn't work? Are you getting the same warning, is it crashing, etc?

[Objective Zero]

Originally Posted by harrytheshark

You're making it its own delegate. Is this your intention?

What do you mean when you say it doesn't work? Are you getting the same warning, is it crashing, etc?

Well I am just trying to achieve the same functionality while fixing these warnings and yes it is the same warning.

[harrytheshark]

Just set the delegate to nil. That'll get rid of the warning.

[Objective Zero]

Thanks that did it, will that effect the functionality though?

Also what did you say I should do to fix #3? I should cast it?

[harrytheshark]

Well yeah of course, it won't have a delegate to call.

Yup, use a cast for 3.

[Objective Zero]

Thanks let me ask you this, with that warning before for #2, would it have worked anyway or no?

[harrytheshark]

Unless FBSession can respond to its own delegate, no. Also, I think at the time you set the delegate, the pointer for FBSession is nothing. No, it wouldn't work.

[Objective Zero]

Hey I have another weird problem with ShareKit leaks here:
Whenever I clearly release something, analyzer complains that there is a leak even though there is not. I am using Beta 5 of the iOS SDK so I don't think its a bug.

A few examples:

self.data = [[NSMutableData alloc] initWithLength:0];
[data release];

if (toggle == nil)
{
self.toggle = [[UISwitch alloc] initWithFrame:CGRectZero];
[self.contentView addSubview:toggle];
[self setValue:tmpValue];
[toggle release];
}

Any ideas?

Thanks!

[harrytheshark]

The analyzer gets stuff wrong, but it's probably better to create temporary pointers then use the setters, rather than what you're doing.

UISwitch * temp = ...
self.toggle = temp;
[temp release];

[Objective Zero]

Alright so this would be the way to do it for the 1st example?:

NSMutableData *tempdata = [[NSMutableData alloc] initWithLength:0];
	self.data = tempdata;
	[tempdata release];

That gets rid of the analyzer warning, [data release]; does not.

[harrytheshark]

Yeah, though initWithLength:0 is the same as init.

[Objective Zero]

Thanks,

I have gotten it down to 6 (Edit: Now 5) leaks/minor analyzer problems left that are a bit different from the others:
(Bold line is where I alloc it)
1.

+ (void)flushOfflineQueue
{
	// TODO - if an item fails, after all items are shared, it should present a summary view and allow them to see which items failed/succeeded
	
	// Check for a connection
	if (![self connected])
		return;
	
	// Open list
	NSMutableArray *queueList = [self getOfflineQueueList];
	
	// Run through each item in the quietly in the background
	// TODO - Is this the best behavior?  Instead, should the user confirm sending these again?  Maybe only if it has been X days since they were saved?
	//		- want to avoid a user being suprised by a post to Twitter if that happens long after they forgot they even shared it.
	if (queueList != nil)
	{
		SHK *helper = [self currentHelper];
		
		if (helper.offlineQueue == nil)
			helper.offlineQueue = [[NSOperationQueue alloc] init];
	
		SHKItem *item;
		NSString *sharerId, *uid;
		
		for (NSDictionary *entry in queueList)
		{
			item = [SHKItem itemFromDictionary:[entry objectForKey:@"item"]];
			sharerId = [entry objectForKey:@"sharer"];
			uid = [entry objectForKey:@"uid"];
			
			if (item != nil && sharerId != nil)
				[helper.offlineQueue addOperation:[[[SHKOfflineSharer alloc] initWithItem:item forSharer:sharerId uid:uid] autorelease]];
		}
		
		// Remove offline queue - TODO: only do this if everything was successful?
		[[NSFileManager defaultManager] removeItemAtPath:[self offlineQueueListPath] error:nil];

	}
}

[FIXED] 2.

- (void)share
{	
	// create sharer
    SHKSharer *tempsharer = [[NSClassFromString(sharerId) alloc] init];
	self.sharer = tempsharer;
	sharer.item = item;
	sharer.quiet = YES;
	sharer.shareDelegate = self;
	
	if (![sharer isAuthorized])		
	{
		[self finish];
		return;
	}
	
	// reload image from disk and remove the file
	NSString *path;
	if (item.shareType == SHKShareTypeImage)
	{
		path = [[SHK offlineQueuePath] stringByAppendingPathComponent:uid];
		sharer.item.image = [UIImage imageWithContentsOfFile:path];
		[[NSFileManager defaultManager] removeItemAtPath:path error:nil];
		
	}
	
	// reload file from disk and remove the file
	else if (item.shareType == SHKShareTypeFile)						
	{
		path = [[SHK offlineQueueListPath] stringByAppendingPathComponent:uid];
		sharer.item.data = [NSData dataWithContentsOfFile:[[SHK offlineQueuePath] stringByAppendingPathComponent:uid]];
		[[NSFileManager defaultManager] removeItemAtPath:path error:nil]; 

	}
	
	[sharer tryToSend];	
    [tempsharer release];
}

I tried it this way like I did for my other problems but no luck.

3.

 /* Wipe variables */
    a = b = c = d = e = 0;

That is not a leak but a value stored to 'a' is never read.

[FIXED]4.

- (void)_generateNonce
{
    CFUUIDRef theUUID = CFUUIDCreate(NULL);
    CFStringRef string = CFUUIDCreateString(NULL, theUUID);
    CFRelease(theUUID);
    nonce = (NSString *)string;
}

The warning is, Potential leak on line 202 (Bolded line)

6. Argument in message expression is an uninitialized value

SHKActionSheet *as = [[SHKActionSheet alloc] initWithTitle:SHKLocalizedString(@"Share")
													  delegate:as
											 cancelButtonTitle:nil
										destructiveButtonTitle:nil
											 otherButtonTitles:nil];
	as.item = [[[SHKItem alloc] init] autorelease];
	as.item.shareType = type;

Those are the only problems left with ShareKit, I would love to share this updated ShareKit with others having these issues too!

Thanks!

[harrytheshark]

You know how to fix 1 and 2 because they're exactly the same problem we discussed earlier.

3. Doesn't make any sense, I don't see a _ anywhere, but I imagine one of those letters is never used - check for that.

4. What's the problem / warning?

5. Which line is it complaining about?

[Objective Zero]

I updated my post above, also don't worry about #5, I fixed that. Also how about 6? Also I am not sure how to fix #1 because it is not a self.whatever, it is a helper.whatever so what would I do in that case? Also, I updated #2's code with the way that should fix it but it stills complains about a leak

Thanks

[harrytheshark]

3. Come on, this is the most simple one.

4. Well yeah, there is a potential leak if "nonce" doesn't get released.

[Objective Zero]

Ok for #3 my best guess is to delete it if it says its not being used right?

Also I updated #4 above with a [noonce release]; and it still shows a warning.

Also recheck all the code because I think I updated it all.

Thanks!

[harrytheshark]

Replace NSMakeCollectable(theUUID); with CFRelease(theUUID);

You don't want to be releasing nonce in the same method, you'll get a crash if it's used elsewhere.

[Objective Zero]

Thanks, that fixed it. Now what about #1,#2,#3, and #6. I thought that just by deleting #3 code line would fix the analyzer warning wouldn't it? And for #1, and #2, I tried your suggestion but I edited my long code post on why/how it didn't work.

[harrytheshark]

For 2 you shouldn't be releasing sharer in that method - you really need to read up on properties. BrianSlick has a good post on them.

[Objective Zero]

Originally Posted by harrytheshark

For 2 you shouldn't be releasing sharer in that method - you really need to read up on properties. BrianSlick has a good post on them.

I updated that code taking out [sharer release]; but it still throws up a analyzer warning in that bolded line. In the meantime I will look over BrianSlick's properties guide but this one just baffles me on why it should be showing a warning whatsoever.