Help with code snippet - memory warning with level 1

[verbatimbot]

Hi guys,
I would like to ask for you opinion on the following code. There are two methods (the first one makes a request for data, and the second one process them). In the app itself it looks like this - on load, app gets the first set of xml data (20 items) that displays in uitableview. At the end 'load more' button appears which brings another set etc.. I have tested cellForRowAtIndexPath method first (by returning an empty cell) just to see if the memory warning will be produced and it does, meaning the cause is probably in one of these two methods.

So i get "Received memory warning. Level=1" after i load 22 pages (thats 22 x 20 = 440 xml items that I hold in my NSMutableArray)

-(void) loadApps:(NSString *)passedMode withPage:(NSInteger)passedPage showActivityIndicator:(BOOL)showIndicator
{
    // showIndicator is YES only for the first time, when the app initially loads the first set of data
    if (showIndicator)
        [self showActivityIndicator];
    
    useActivityIndicator = showIndicator;
    
    page = passedPage;
    [mode setString:passedMode];
    
    // Create the request.
    NSMutableString *apiUrl = [[NSMutableString alloc] initWithFormat:@"%@?mode=newest", [AppSettings getServiceUrl]];
    [apiUrl appendFormat:@"&page=%d",passedPage];
    [apiUrl appendFormat:@"&view=%@",mode];
    
    NSMutableURLRequest *theRequest = [NSMutableURLRequest requestWithURL:[NSURL URLWithString:apiUrl]
                                              cachePolicy:NSURLRequestUseProtocolCachePolicy
                                          timeoutInterval:60.0];
    

    [UrlRequestManager addHeaders:theRequest];
    
    
    [apiUrl release];
    // create the connection with the request
    // and start loading the data
    serviceCallInProgress = YES;
    NSURLConnection *theConnection = [[NSURLConnection alloc] initWithRequest:theRequest delegate:self];
    
    if (theConnection) {
        // Create the NSMutableData to hold the received data.
        // receivedData is an instance variable declared elsewhere.
        NSMutableData *md = [[NSMutableData alloc] init];
        [self setReceivedData:md];
        [md release];
    }
    
    [theConnection release];
}

- (void)connectionDidFinishLoading:(NSURLConnection *)connection
{
    NSLog(@"Received response, connectionDidFinishLoading begun...");
    serviceCallInProgress = NO;
    
    CXMLDocument *doc = [[CXMLDocument alloc] initWithData:[self receivedData] options:0 error:nil];
    
    
    
    NSArray *nodes = [doc nodesForXPath:@"//ItunesRecordObject" error:nil];
    
    int counter = 0;
    for(CXMLNode *node in nodes)
    {
        counter++;
        
        
        NSString *str = [[NSString alloc] initWithString:[[node nodeForXPath:@"Stars" error:nil] stringValue]];
        
        NSMutableDictionary *d = [[NSMutableDictionary alloc] initWithObjectsAndKeys:
                                  [[node nodeForXPath:@"Id" error:nil] stringValue], @"id", 
                                  [[node nodeForXPath:@"TrackName" error:nil] stringValue], @"name", 
                                  [[node nodeForXPath:@"ArtistName" error:nil] stringValue], @"artist", 
                                  [[node nodeForXPath:@"Genre" error:nil] stringValue], @"genre", 
                                  [[node nodeForXPath:@"Price" error:nil] stringValue], @"price", 
                                  [[node nodeForXPath:@"ThumbnailImage" error:nil] stringValue], @"imageurl", 
                                  [[node nodeForXPath:@"PrettyDate" error:nil] stringValue], @"releasedate", 
                                  [[node nodeForXPath:@"Permalink" error:nil] stringValue], @"permalink", 
                                  [[node nodeForXPath:@"RatesCount" error:nil] stringValue], @"ratescount", 
                                  [[node nodeForXPath:@"CommentsCount" error:nil] stringValue], @"commentscount",
                                  [[node nodeForXPath:@"IsFeatured" error:nil] stringValue], @"featured",
                                  str, @"rate",
                                  nil, @"image", 
                                  nil];
        
        [[self dataSourceArray] addObject:d];
        [d release];
        
        // add to existing or create a new section record
        bool exists = NO;
        for (int i=0; i<[sections count]; i++)
        {
            NSMutableDictionary *dict = [[self sections] objectAtIndex:i];           
            
            
            if ([[dict objectForKey:@"releasedate"] isEqualToString:[[node nodeForXPath:@"Group" error:nil] stringValue]])
            {
                
                
                exists = YES;
                int count = [[dict objectForKey:@"count"] intValue];
                count++;
                
                [dict setValue:[NSString stringWithFormat:@"%d", count] forKey:@"count"];
                
                
                break;
            }
        }
        
        if (!exists)
        {
            // add new one
            NSString *relDate = [[NSString alloc] initWithString:[[node nodeForXPath:@"Group" error:nil] stringValue]];
            
            NSMutableDictionary *dict = [[NSMutableDictionary alloc] initWithObjectsAndKeys:relDate, @"releasedate", @"1", @"count", [NSString stringWithFormat:@"%d", [sections count]], @"section", nil];
            [[self sections] addObject:dict];
            [dict release];
            [relDate release];
        }
        
        
        [str release];
    }
    
    
    if ([[doc nodeForXPath:@"//TotalPages" error:nil] stringValue] != nil)
    {
        NSString *totalPagesStr = [[NSString alloc] initWithString:[[doc nodeForXPath:@"//TotalPages" error:nil] stringValue]];
        totalPages = [totalPagesStr intValue];
        [totalPagesStr release];
    }
    
    [[self tableViewList] setDelegate:self];
    [[self tableViewList] setDataSource:self];
    
    [[self tableViewList] reloadData];
    tableViewList.hidden = NO;
    
    
    
    if (page == 1)
    {
        [self hideActivityIndicator];
        [[self tableViewList] scrollToRowAtIndexPath:[NSIndexPath indexPathForRow:0 inSection:0] atScrollPosition:UITableViewScrollPositionTop animated:NO];
    }
    
    
    //[receivedData release];
    [doc release];
    
    // release the connection, and the data object
    //[connection release];
    NSLog(@"connectionDidFinishLoading completed.");
}

Any help would be very much appreciated.

[smithdale87]

Have you tried running the build & analyze tool to see if it will identify any potential memory leaks?

[verbatimbot]

Just reported a few 'object sent -autorelease too many times', like this one in the IF selection. Any idea what can this be?

-(UITableViewCell *) tableView:(UITableView *)tableView cellForRowAtIndexPath:(NSIndexPath *)indexPath
{
    if (indexPath.row == [comments count])
    {
        UITableViewCell *c = [tableView dequeueReusableCellWithIdentifier:@"Cell"];
        if (c == nil) {
            c = [[[[UITableViewCell alloc] initWithStyle:UITableViewCellStyleDefault reuseIdentifier:@"Cell"] autorelease] initWithFrame:CGRectMake(5, 5, 60, 60)];
        }  
        
        if ([self.comments count] > 0) // *** object sent -autorelease too many times
        {
...