How can i fix this memory leak?

[AyClass]

hi im creating a soundboard and everything works fine when running the app but i have many memory leaks can someone see whats wrong?

.m

-(IBAction)oldskool {
    CFBundleRef mainBundle = CFBundleGetMainBundle();
    CFURLRef soundFileURLRef;
    soundFileURLRef = CFBundleCopyResourceURL(mainBundle, (CFStringRef) @"oldskool",CFSTR ("wav"),NULL);
    
    UInt32 soundID;
    AudioServicesCreateSystemSoundID(soundFileURLRef, &soundID);
    AudioServicesPlaySystemSound(soundID);
    
}

[baja_yu]

If you check the documentation for CFBundleCopyResourceURL, it's pretty easy to figure out.

See here: Loading…

It says

Return Value
A CFURL object describing the location of the requested resource, or NULL if the resource cannot be found. Ownership follows the Create Rule.

And the Create Rule is: Loading…

So your answer is: CFRelease

[AyClass]

Originally Posted by baja_yu

If you check the documentation for CFBundleCopyResourceURL, it's pretty easy to figure out.

See here: Loading…

It says



And the Create Rule is: Loading…

So your answer is: CFRelease

Thankyou very much

in my case it would be

CFRelease(soundFileURLRef);

right?

[baja_yu]

Bingo!

[AyClass]

haha Thanks!

by the way is this an appropriate way of playing a sound when a button is pressed? i see many others doing it a different way

im using the audiotoolbox framwork

[baja_yu]

There's a few ways to go about it. The choice of which depends on the file itself (format, length) and its purpose. There's a section of the Multimedia Programming guide devoted to it which explains which is used when: Loading…