Xcode problems

[nagol2013]

Hi, I am working on an application and part of it is to let the user type something in a text field and search it via google. Right now I have it linked to google and when the user presses search its transitions to the webView. My problem is that I can't get xcode to take what the user has typed into the text field and insert it into the google link properly. Right now it just shows a search of "(null)" in the webView. I was wondering if anyone can help me resolve this.

NSLog(@"%@",searchBarGoogle.text);
NSString *string1 = [[NSString alloc] initWithFormat:@"%@",searchBarGoogle.text];
NSString *string = [NSString stringWithFormat:@"http://www.google.com/search?q=%@",string1];
NSURL *url = [NSURL URLWithString:string];
NSURLRequest *request = [NSURLRequest requestWithURL:url];
[webView loadRequest:request];

Thanks in advance for future help!

[baja_yu]

There's no need for string1, and you're leaking it as well. What's in the search filed? Are you sure URLWithString is returning you anything? It the string you pass it is not valid for an URL it will return nil. You should be checking the user input and escaping the characters that need to be escaped.

[nagol2013]

Why isnt this code working?



NSString *string = [searchBarGoogle.text stringByReplacingOccurrencesOfString:@" " withString:@"+"];
NSURL *url = [NSURL URLWithString:[NSString stringWithFormat:@"http://www.google.com/search?q=%@", string]];
[NSString stringWithFormat:@"%d%%", 1];
NSURLRequest *request = [NSURLRequest requestWithURL:url];
[webView loadRequest:request];

[baja_yu]

1. Please use [code] tags around code when posting
2. The space character is not the only one that needs to be escaped. Check out stringByAddingPercentEscapesUsingEncoding method of NSString on how to do it properly.
3. What is this line supposed to do:

[NSString stringWithFormat:@"%d%%", 1];

4. Did you try to do some debugging to see why it doesn't work? For example print out the value of "url" (NSUrl object) to see if it gave you a valid object at all and so on.

[nagol2013]

that line is percent escaping the % i believe

[baja_yu]

No it's not. Even if you read the return value it still isn't. But as is, it just creates an NSString object which just floats away as a helium filled balloon before eventually being popped.