Pointer not released !

[manojb]

hey guys,

Here in my code, i add sections to a tableview from webservice. for every section, i have an item array whose values are also obtained from the webservice. now the problem is if i have 2 sections, the item array first loads the items to the first section, then on fetching the items of second section, it again loads the items to the first section.... I can detect that the pointer reference to both are same.

if (dataOption == kLoadItems) {

            ItemSection *itemSection = [[IitemSection alloc] init];
            if (itemSection != nil) {
                itemSection = nil; [itemSection release];
            }
            itemSection = [itemController.itemSectionList objectAtIndex:_selectedSectionIndex];
            itemSection.itemList = (NSMutableArray*)[data dataObject];
        }
[_tableView reloadData];

the dataObject brings the items array from the webservice and it does contain valid data.

Kindly help me how i could load the items in the two sections...

[dany_dev]

i dont' understand why you are allocing and then release the line below.

However you would have 1 array of objects for each sections,

If i understand what you mean, you have

itemSection = [itemController.itemSectionList objectAtIndex:_selectedSectionIndex];

where you are using this array itemController.itemSectionList for both sections....so as said, you need to have 2 different array...so that you can use the right array depending on indexPath.section

[RLScott]

Originally Posted by manojb

            ItemSection *itemSection = [[IitemSection alloc] init];
            if (itemSection != nil) {
                itemSection = nil; [itemSection release];
            }
            itemSection = [itemController.itemSectionList objectAtIndex:_selectedSectionIndex];
            itemSection.itemList = (NSMutableArray*)[data dataObject];

Like dany_dev said, that alloc and release doesn't make sense. Here is what actually happens when you do that. A new ItemSection is allocated and itemSection is made to point at it. Since it is probably not nil, it goes into the next block of code. There you first set itemSection to nil. This immediately creates a leak, because now the ItemSection that was just allocated now has nothing pointing to it, so there is no way to ever release it. The you "try" to release it. But you are trying to release it through a pointer that is already set to nil, so it does nothing. (release is designed to do nothing when applied to nil, so it is not an error.) Next, you are outside the "if" block and you now assign itemSection to something in an array, which may or may not be an error - depending on what is in that array. But the only effect of your "if" block was to produce a leak. If you had just done the release before making the pointer nil, then there would be no leak.

[manojb]

Originally Posted by dany_dev

i dont' understand why you are allocing and then release the line below.

However you would have 1 array of objects for each sections,

If i understand what you mean, you have

itemSection = [itemController.itemSectionList objectAtIndex:_selectedSectionIndex];

where you are using this array itemController.itemSectionList for both sections....so as said, you need to have 2 different array...so that you can use the right array depending on indexPath.section

Thanks dany, that was an attempt to release the pointer reference in my sections array. I coded originally like,

if (dataOption == kLoadItems) {
            itemSection = [itemController.itemSectionList objectAtIndex:_selectedSectionIndex];
            itemSection.itemList = (NSMutableArray*)[data dataObject];
        }
[_tableView reloadData];