Timer Problem how to invalidate

[marshusensei]

Hello again, another problem that seemed simple but is driving me bananas.

I have a timer that counts down -1 over a number of views. It works fine the first time, but if I return to the first view, the timer counts down -2. if I do this a third time it counts down -3 and so on.

I need to know how to reset the timer.

I think I have to use invalidate and an if statement, but I just can't work out where to put it?

Any advice?

Here is my .h

#import <UIKit/UIKit.h>
#import "PicPuzzleAppDelegate.h"
#import "puzzle2.h"


@interface puzzle1 : UIViewController {

    IBOutlet UILabel *theScore;
    IBOutlet UILabel *theTime;
    NSInteger counter;
    
}

@property (retain, nonatomic) UILabel *theScore;
@property (retain, nonatomic) UILabel *theTime;
@property (nonatomic, readwrite) NSInteger counter;


-(IBAction)correct1;
-(IBAction)HomeButton;
-(IBAction)pushforward;



@end

and here is part of my .m code ( I think the problem lies in this section)

- (void)viewDidLoad

{ //CHECK TIMer?
    
    PicPuzzleAppDelegate *PicPuzzle = (PicPuzzleAppDelegate *)[[UIApplication sharedApplication]delegate];
    
    //set timer
    PicPuzzle.minutes = 5.00;
    PicPuzzle.seconds = 0.00;
    
	// Start the timer for the countdown
	PicPuzzle.timer = [NSTimer scheduledTimerWithTimeInterval:1.0 target:self selector:@selector(countDown) userInfo:nil repeats:YES];
    
    //set score to 0
    PicPuzzle.data = 0;
    [super viewDidLoad];
    }

-(void)countDown
{
    PicPuzzleAppDelegate *PicPuzzle = (PicPuzzleAppDelegate *)[[UIApplication sharedApplication]delegate];
	// Question live counter

    {
    
        theTime.text = [NSString stringWithFormat:@"%i:%2i",PicPuzzle.minutes, PicPuzzle.seconds];
        
        
        if (PicPuzzle.seconds >= 1) { 
            PicPuzzle.seconds = PicPuzzle.seconds - 1;
        }
        
    else {
            PicPuzzle.minutes = PicPuzzle.minutes - 1;
            PicPuzzle.seconds = 59;
            
            }
       }
    
    if(PicPuzzle.minutes == 0 && PicPuzzle.seconds ==0) 
        {
            puzzleEnd *screen = [[puzzleEnd alloc] initWithNibName:nil bundle:nil];
            screen.modalTransitionStyle = UIModalTransitionStyleCoverVertical;
            [self presentModalViewController:screen animated:YES];
            
            [screen release];
        }
        
      //  [self pushforward];}
}

I've tried putting:

/* if(PicPuzzle.timer){
        [PicPuzzle.timer invalidate];
        PicPuzzle.timer = nil;*/

but not sure where, and it won't work.

Can someone show me what I'm doing wrong?

Cheers guys.

Marshu

[Domele]

Set up the timer in viewWillAppear and invalidate in viewWillDisappear.

[Goldoneh]

You have one counter start from 5min to down, So you should check timer when receive to 00:00, you show alert and invalidate the timer.

[marshusensei]

thanks for you advice guys.

It works for the first view, but if I exit on the 2nd view and restart, the timer takes -2.

Hmm.

[pure]

Originally Posted by marshusensei

thanks for you advice guys.

It works for the first view, but if I exit on the 2nd view and restart, the timer takes -2.

Hmm.

How About trying to add 2 second to the second view that may help

[marshusensei]

thanks for all your help guys. I really appreciate this board. I post a question, and no matter how stupid or simple it is, someone on here responds.
I hope to become more involved in this forum community.

I have learnt so much from others on here, and hope that soon I will be able to offer the same kind of advice that has been given me.

I got the timer working without using invalidate at all...
I simply created a second "selector" and used this with an if statement. Works, but I have a feeling this is a "dirty" method.

[Domele]

One question, by counting down -1, you mean it goes 5 minutes, 4 minutes 59 seconds, 4 minutes 58 seconds, etc. right? And -2 it goes down by 2 seconds right? If so I have an idea on how to solve your problem. This is assuming your timer is never canceled manually and is only canceled on its own when it reaches 0.

if (PicPuzzle.timer == nil) {
//start and configure timer
}