Memory leak problem using NSXMLParser

[mramin05]

Hi guys,
In my app I have xml parser( NSXMLParser) to parse rss data.
But I could not detect the memory leak in my parsing code. I have tried every possible way by me. But "Start with performance->Leaks" shows memory leak. I am afraid to be rejected from apple.
Here is my code
TopDataReader.h

#import <Foundation/Foundation.h>


@interface TopDataReader : NSObject {

	NSXMLParser * rssParser;
	NSMutableArray * stories;
	// a temporary item; added to the "stories" array one at a time, and cleared for the next one
	NSMutableDictionary * item;
	
	NSString * currentElement;
	NSMutableString * currentTitle, * currentCategoryId, * currentId, * currentPubDate, *currentDescription , *currentImgLink;
	NSNumber *pageNUmber;
}

@property(nonatomic,retain) NSMutableString * currentTitle;
@property(nonatomic,retain) NSMutableString * currentCategoryId;
@property(nonatomic,retain) NSMutableString * currentId;
@property(nonatomic,retain) NSMutableString * currentPubDate;
@property(nonatomic,retain) NSMutableString * currentDescription;
@property(nonatomic,retain) NSMutableString * currentImgLink;
@property(nonatomic,retain) NSNumber *pageNUmber;

- (void)loadNewsData:(int)pageNumber;
- (NSMutableArray*)getXMLData;

@end

TopDataReader.m

#import "TopDataReader.h"


@implementation TopDataReader

@synthesize currentTitle, currentCategoryId, currentId, currentPubDate, currentDescription , currentImgLink;
@synthesize pageNUmber;

- (void)loadNewsData:(int)pageNumber {

	self.pageNUmber= [NSNumber numberWithInt: pageNumber];
	// Added parser code
	
	NSString * path = [NSString stringWithFormat:@"http://myurl?page=%d",pageNumber];
	
	self parseXMLFileAtURL:path];
	
}

- (NSMutableArray*)getXMLData{
	
	return stories;
}


- (void)parseXMLFileAtURL:(NSString *)URL
{	
	
	stories = [[NSMutableArray alloc] init];

    //you must then convert the path to a proper NSURL or it won't work
    NSURL *xmlURL = [NSURL URLWithString:URL];

    rssParser = [[NSXMLParser alloc] initWithContentsOfURL:xmlURL];
	
    // Set self as the delegate of the parser so that it will receive the parser delegate methods callbacks.
    [rssParser setDelegate:self];
	
    // Depending on the XML document you're parsing, you may want to enable these features of NSXMLParser.
    [rssParser setShouldProcessNamespaces:NO];
    [rssParser setShouldReportNamespacePrefixes:NO];
    [rssParser setShouldResolveExternalEntities:NO];
	
    [rssParser parse];
	

}

- (void)parser:(NSXMLParser *)parser parseErrorOccurred:(NSError *)parseError {

}

- (void)parser:(NSXMLParser *)parser didStartElement:(NSString *)elementName namespaceURI:(NSString *)namespaceURI qualifiedName:(NSString *)qName attributes:(NSDictionary *)attributeDict{			
  
	currentElement = [elementName copy];
	if ([elementName isEqualToString:@"item"]) {
		// clear out our story item caches...
		item = [[[NSMutableDictionary alloc] init] autorelease];
		currentTitle = [[[NSMutableString alloc] init] autorelease];
		currentCategoryId = [[[NSMutableString alloc] init] autorelease];
		currentId = [[[NSMutableString alloc] init]autorelease];
		currentPubDate = [[[NSMutableString alloc] init] autorelease];
		currentDescription = [[[NSMutableString alloc] init] autorelease];
		currentImgLink = [[[NSMutableString alloc] init] autorelease];
		
	}
	
}

- (void)parser:(NSXMLParser *)parser didEndElement:(NSString *)elementName namespaceURI:(NSString *)namespaceURI qualifiedName:(NSString *)qName{     
	
	if ([elementName isEqualToString:@"item"]) {
		
		[item setObject:currentTitle forKey:@"title"];
		[item setObject:currentCategoryId forKey:@"category"];
				
		[item setObject:currentId forKey:@"id"];
		
		[item setObject:currentPubDate forKey:@"pubDate"];
		[item setObject:currentDescription forKey:@"description"];
		[item setObject:currentImgLink forKey:@"image_link"];
		// Trim white space
		currentImgLink = [currentImgLink stringByTrimmingCharactersInSet: [NSCharacterSet whitespaceCharacterSet]];
		
		NSURL *imageUrl = [NSURL URLWithString: currentImgLink];
		
		NSData *nsDataImage = [NSData dataWithContentsOfURL: imageUrl];
		
		if(nsDataImage != nil){
						
			[item setObject:nsDataImage forKey:@"itemImageData"];
		}
		
		
		[stories addObject:[item copy]];
	
	}
	
}

- (void)parser:(NSXMLParser *)parser foundCharacters:(NSString *)string{
	
	if ([currentElement isEqualToString:@"title"]) {
		[currentTitle appendString:string];
	} else if ([currentElement isEqualToString:@"category"]) {
		[currentCategoryId appendString:string];
	} else if ([currentElement isEqualToString:@"id"]) {
		[currentId appendString:string];
	} else if ([currentElement isEqualToString:@"pubDate"]) {
		[currentPubDate appendString:string];
	} else if ([currentElement isEqualToString:@"description"]) {
		[currentDescription appendString:string];
	} else if ([currentElement isEqualToString:@"ldnfeed:image_link"]) {
		[currentImgLink appendString:string];
	}
	
}

- (void)parserDidEndDocument:(NSXMLParser *)parser {
   NSLog(@"%d", [stories count]);
}


- (void)dealloc {
	if(currentElement != nil){
		[currentElement release];
		currentElement =nil;
	}
	if( rssParser!=nil){
		[rssParser release];
		rssParser =nil;
	}
	if( stories!=nil){
		[stories release];
		stories =nil;
	}
	if( item!=nil){
		[item release];
		item = nil;
	}
	if( currentTitle!=nil){
		[currentTitle release];
		currentTitle = nil;
	}
	if( currentId!=nil){
		[currentId release];
		currentId = nil;
	}
	if( currentCategoryId!=nil){
		[currentCategoryId release];
		currentCategoryId = nil;
	}
	if( currentDescription!=nil){
		[currentDescription release];
		currentDescription = nil;
	}
	if( currentImgLink!=nil){
		[currentImgLink release];
		currentImgLink = nil;
	}
	
	
	[super dealloc];
}

@end

Please help me.

[BrianSlick]

currentElement = [elementName copy];

You leak this on each pass.

You are not using your properties. You should. And you should have properties for all of your instance variables.

[mramin05]

Originally Posted by BrianSlick

currentElement = [elementName copy];

You leak this on each pass.

You are not using your properties. You should. And you should have properties for all of your instance variables.

Thx for reply.
I made it as below..

currentElement = [[[NSString alloc] initWithString:elementName] autorelease];

I made remaining items as properties.

Please see the image for the block which create leak
Memory Leak | Flickr - Photo Sharing!
Is it ok?
Still leaking.

[BrianSlick]

I suggest you go read the properties link in my signature, as you don't seem to know how to use them.

[mramin05]

Originally Posted by BrianSlick

I suggest you go read the properties link in my signature, as you don't seem to know how to use them.

HI BrianSlick,
Thanks for your advice. I have tried to utilize you advice. My current code is as below which have leak yet at "parser didStartElement" block.

#import <Foundation/Foundation.h>


@interface PostXMLReader : NSObject {
	
	NSXMLParser * rssParser;
	NSMutableArray * stories;
	NSMutableDictionary * item;
	NSString * currentElement;
	NSMutableString * currentTitle, * currentCategoryId, * currentId, * currentPubDate, *currentDescription , *currentImgLink;
	NSNumber *pageNUmber;
}

@property(nonatomic,retain) NSMutableString * currentTitle;
@property(nonatomic,retain) NSMutableString * currentCategoryId;
@property(nonatomic,retain) NSMutableString * currentId;
@property(nonatomic,retain) NSMutableString * currentPubDate;
@property(nonatomic,retain) NSMutableString * currentDescription;
@property(nonatomic,retain) NSMutableString * currentImgLink;
@property(nonatomic,retain) NSNumber *pageNUmber;

@property(nonatomic,retain) NSXMLParser * rssParser;
@property(nonatomic,retain) NSMutableArray * stories;
@property(nonatomic,retain) NSMutableDictionary * item;
@property(nonatomic,retain) NSString * currentElement;


- (void)loadNewsRankData:(int)pageNumber;

@end

Here is my Implementation:

#import "PostXMLReader.h"


@implementation PostXMLReader


@synthesize currentTitle, currentCategoryId, currentId, currentPubDate, currentDescription , currentImgLink;
@synthesize pageNUmber;
@synthesize rssParser;
@synthesize stories;
@synthesize item;
@synthesize currentElement;

- (void)loadNewsRankData:(int)pageNumber {
	//NSLog(@"Top loader Loaded");
	self.pageNUmber= [NSNumber numberWithInt: pageNumber];
	// Added parser code
	
	//if ([stories count] == 0) {
	NSString * path = [NSString stringWithFormat:@"http://myurl/rssnewsrank.php?page=%d",pageNumber];
	//NSLog(@"Path %@", path);
	[self parseXMLFileAtURL:path];
	
	if(path !=nil){
		path = nil;
	}
	//}
	
}

- (NSMutableArray*)getXMLData{
	
	return stories;
}


- (void)parseXMLFileAtURL:(NSString *)URL
{	
	NSLog(@"parseXMLFileAtURL function at topdatareader loaded");
	
	@try {
		
		NSLog(@"Retain count before %d", [stories retainCount]);
		
		NSMutableArray *tmpStories = [[NSMutableArray alloc] init];
		
		[self setStories: tmpStories ];
		[tmpStories release];
		tmpStories = nil;
		
		NSLog(@"Retain count after %d", [stories retainCount]);
		
		//you must then convert the path to a proper NSURL or it won't work
		NSURL *xmlURL = [NSURL URLWithString:URL];
		
		[self setRssParser:[[[NSXMLParser alloc] initWithContentsOfURL:xmlURL] autorelease]];
		
		// Set self as the delegate of the parser so that it will receive the parser delegate methods callbacks.
		[rssParser setDelegate:self];
		
		// Depending on the XML document you're parsing, you may want to enable these features of NSXMLParser.
		[rssParser setShouldProcessNamespaces:NO];
		[rssParser setShouldReportNamespacePrefixes:NO];
		[rssParser setShouldResolveExternalEntities:NO];
		
		[rssParser parse];
	}
	@catch (NSException * e) {
		
		NSLog(@"Parsing error ");
	}
}

- (void)parser:(NSXMLParser *)parser parseErrorOccurred:(NSError *)parseError {
	NSLog(@"Parse Error ");
}

- (void)parser:(NSXMLParser *)parser didStartElement:(NSString *)elementName namespaceURI:(NSString *)namespaceURI qualifiedName:(NSString *)qName attributes:(NSDictionary *)attributeDict{			
    //NSLog(@"found this element: %@", elementName);
	NSString *tmpCurElement = [[NSString alloc] initWithString:elementName];
	[self setCurrentElement: tmpCurElement];
	[tmpCurElement release];
	tmpCurElement = nil;						   
							   
	if ([elementName isEqualToString:@"item"]) {
		// clear out our story item caches...
		NSMutableDictionary *tmpItem = [[NSMutableDictionary alloc] init];
		[self setItem: tmpItem];
		[tmpItem release];
		tmpItem = nil;
		
		NSMutableString *tmpCurrentTitle = [[NSMutableString alloc] init];
		[self setCurrentTitle:tmpCurrentTitle ];
		[tmpCurrentTitle release];
		tmpCurrentTitle = nil;
		
		NSMutableString *tmpCurCatID = [[NSMutableString alloc] init];
		[self setCurrentCategoryId: tmpCurCatID];
		[tmpCurCatID release];
		tmpCurCatID = nil;
							
		NSMutableString *tmpCurID = [[NSMutableString alloc] init];
		[self setCurrentId:tmpCurID];
		[tmpCurID release];
		tmpCurID = nil;
										   
		NSMutableString	*tmpCurPubDate =[[NSMutableString alloc] init];
		[self setCurrentPubDate: tmpCurPubDate];
		[tmpCurPubDate release];
		tmpCurPubDate = nil;
		
		NSMutableString	*tmpCurDescription =[[NSMutableString alloc] init];
		[self setCurrentDescription: tmpCurDescription];
		[tmpCurDescription release];
		tmpCurDescription = nil;
								
		NSMutableString	*tmpCurImgLink =[[NSMutableString alloc] init];								   
		[self setCurrentImgLink:tmpCurImgLink];
		[tmpCurImgLink release];
		tmpCurImgLink = nil;
		
	}
	
}

- (void)parser:(NSXMLParser *)parser didEndElement:(NSString *)elementName namespaceURI:(NSString *)namespaceURI qualifiedName:(NSString *)qName{     
	//NSLog(@"ended element: %@", elementName);
	if ([elementName isEqualToString:@"item"]) {
		
		[item setObject:currentTitle forKey:@"title"];
		[item setObject:currentCategoryId forKey:@"category"];
		
		//NSString *tmpCurrentId = [NSString stringWithFormat:@"%@",currentId];
		
		//tmpCurrentId = [tmpCurrentId stringByReplacingOccurrencesOfString:@" " withString:@""];
		//tmpCurrentId = [tmpCurrentId stringByReplacingOccurrencesOfString:@"\n" withString:@""];
		//tmpCurrentId = [tmpCurrentId stringByReplacingOccurrencesOfString:@"	" withString:@""];
		
		//currentId = [NSMutableString stringWithString:tmpCurrentId];
		
		[item setObject:currentId forKey:@"id"];
		
		[item setObject:currentPubDate forKey:@"pubDate"];
		[item setObject:currentDescription forKey:@"description"];
		[item setObject:currentImgLink forKey:@"image_link"];
		// Trim white space
		//currentImgLink = [currentImgLink stringByTrimmingCharactersInSet: [NSCharacterSet whitespaceCharacterSet]];
		
		//NSURL *imageUrl = [NSURL URLWithString: currentImgLink];
		
		//NSData *nsDataImage = [NSData dataWithContentsOfURL: imageUrl];
		
		//UIImage *itemImage = [[UIImage imageWithData: [NSData dataWithContentsOfURL: imageUrl]] retain];
		//if(nsDataImage != nil){
			//UIImage *img = [UIImage imageNamed:@"some.png"];
			
			//NSData *nsDataImage = UIImageJPEGRepresentation(itemImage, 1.0);
			
		//	[item setObject:nsDataImage forKey:@"itemImageData"];
		//}
		NSLog(@"Retain count before adding  %d", [stories retainCount]);
		id newItem = [item copy];
		[stories addObject:newItem];
		[newItem release];
		newItem = nil;
		NSLog(@"Retain count after adding  %d", [stories retainCount]);
		//[stories addObject:[item copy]];
		
		//NSLog(@"adding story: %@", currentTitle);
		//NSLog(@"Total :%d", [stories count]);
		//NSLog(@"Total End");
	}
	
}

- (void)parser:(NSXMLParser *)parser foundCharacters:(NSString *)string{
	//NSLog(@"found characters: %@ %@", currentElement, string);
	
	NSString *tmpString = [[NSString alloc] initWithString:string];
	
	@try {
		
		// save the characters for the current item...
		if ([currentElement isEqualToString:@"title"]) {
			[currentTitle appendString:tmpString];
		} else if ([currentElement isEqualToString:@"category"]) {
			[currentCategoryId appendString:tmpString];
		} else if ([currentElement isEqualToString:@"id"]) {
			[currentId appendString:tmpString];
		} else if ([currentElement isEqualToString:@"pubDate"]) {
			[currentPubDate appendString:tmpString];
		} else if ([currentElement isEqualToString:@"description"]) {
			[currentDescription appendString:tmpString];
		} else if ([currentElement isEqualToString:@"imgicon"]) {
			[currentImgLink appendString:tmpString];
		}
		
		[tmpString release];
		tmpString = nil;
	}
	@catch (NSException * e) {
		
		if(tmpString != nil){
			[tmpString release];
			tmpString = nil;
		}
		
	}
	
}

- (void)parserDidEndDocument:(NSXMLParser *)parser {
	NSUserDefaults *prefs = [NSUserDefaults standardUserDefaults];
	NSLog(@"Retain count parserDidEndDocument: %d", [stories retainCount]);
	NSLog(@"%d", [stories count]);
	[prefs setObject:stories forKey:@"com.mycompany.newsRanklist"];
	[prefs synchronize];
	
}


- (void)dealloc {
	if(currentElement != nil){
		NSLog(@"1");
		[currentElement release];
		currentElement =nil;
	}
	if( rssParser!=nil){
		NSLog(@"2");
		[rssParser release];
		rssParser =nil;
	}
	if( stories!=nil){
		NSLog(@"3");
		NSLog(@"Retain count %d", [stories retainCount]);
		[stories release];
		stories =nil;
		NSLog(@"Retain count %d", [stories retainCount]);
	}
	if( item!=nil){
		NSLog(@"4");
		[item release];
		item = nil;
	}
	if( currentTitle!=nil){
		[currentTitle release];
		currentTitle = nil;
	}
	if( currentId!=nil){
		[currentId release];
		currentId = nil;
	}
	if( currentCategoryId!=nil){
		[currentCategoryId release];
		currentCategoryId = nil;
	}
	if( currentDescription!=nil){
		[currentDescription release];
		currentDescription = nil;
	}
	if( currentImgLink!=nil){
		[currentImgLink release];
		currentImgLink = nil;
	}
	
	
	[super dealloc];
}

@end

I found in leak details that this line create leak 100%(XCode display that)

NSMutableString	*tmpCurPubDate =[[NSMutableString alloc] init];

Can u help me? I have already waste 2 days in this issue.

Please please.....

Thanks in Advance.

-- Amin

[BrianSlick]

That line alone is not a leak. You have misinterpreted the result.

All retain and copy properties should be released in dealloc. You are not releasing that one, which could explain that leak.

[mramin05]

Originally Posted by BrianSlick

All retain and copy properties should be released in dealloc. You are not releasing that one, which could explain that leak.

Thank a lot. I have changed according to your advice now the leak is in GeneralBlock.

Here is my code

#import <Foundation/Foundation.h>


@interface PostXMLReader : NSObject < NSXMLParserDelegate> {
	
	NSXMLParser * rssParser;
	NSMutableArray * stories;
	NSMutableDictionary * item;
	NSString * currentElement;
	NSMutableString * currentTitle, * currentCategoryId, * currentId, * currentPubDate, *currentDescription , *currentImgLink;
	NSNumber *pageNumber;
}

@property(nonatomic,retain) NSMutableString * currentTitle;
@property(nonatomic,retain) NSMutableString * currentCategoryId;
@property(nonatomic,retain) NSMutableString * currentId;
@property(nonatomic,retain) NSMutableString * currentPubDate;
@property(nonatomic,retain) NSMutableString * currentDescription;
@property(nonatomic,retain) NSMutableString * currentImgLink;
@property(nonatomic,retain) NSNumber *pageNumber;

@property(nonatomic,retain) NSXMLParser * rssParser;
@property(nonatomic,retain) NSMutableArray * stories;
@property(nonatomic,retain) NSMutableDictionary * item;
@property(nonatomic,retain) NSString * currentElement;


- (void)loadNewsRankData:(int)pageNumberParam;


@end

And IMplementation:

#import "PostXMLReader.h"


@implementation PostXMLReader


@synthesize currentTitle, currentCategoryId, currentId, currentPubDate, currentDescription , currentImgLink;
@synthesize pageNumber;
@synthesize rssParser;
@synthesize stories;
@synthesize item;
@synthesize currentElement;

- (void)loadNewsRankData:(int)pageNumberParam {
	//NSLog(@"Top loader Loaded");
	//self.pageNumber= [NSNumber numberWithInt: pageNumber];
	
	NSNumber *tmpPageNum = [[NSNumber alloc] initWithInt:pageNumberParam];
	[self setPageNumber: tmpPageNum];
	[tmpPageNum release];
	tmpPageNum = nil;
	
	// Added parser code
	
	//if ([stories count] == 0) {
	NSString * path = [NSString stringWithFormat:@"http://myurl/rssnewsrank.php?page=%d",pageNumber];
	//NSLog(@"Path %@", path);
	[self parseXMLFileAtURL:path];
	
	if(path !=nil){
		path = nil;
	}
	//}
	
}

- (NSMutableArray*)getXMLData{
	
	return stories;
}


- (void)parseXMLFileAtURL:(NSString *)URL
{	
	NSLog(@"parseXMLFileAtURL function at topdatareader loaded");
	
	@try {
		
		NSLog(@"Retain count before %d", [stories retainCount]);
		
		NSMutableArray *tmpStories = [[NSMutableArray alloc] init];
		
		[self setStories: tmpStories ];
		[tmpStories release];
		tmpStories = nil;
		
		NSLog(@"Retain count after %d", [stories retainCount]);
		//stories = [[NSMutableArray alloc] init];
		
		//you must then convert the path to a proper NSURL or it won't work
		NSURL *xmlURL = [NSURL URLWithString:URL];
		
		NSXMLParser *tmpRssParser =[[NSXMLParser alloc] initWithContentsOfURL:xmlURL];
		
		[self setRssParser:tmpRssParser ];
		[tmpRssParser release];
		tmpRssParser = nil;
		xmlURL = nil;
		URL = nil;
		// Set self as the delegate of the parser so that it will receive the parser delegate methods callbacks.
		[rssParser setDelegate:self];
		
		// Depending on the XML document you're parsing, you may want to enable these features of NSXMLParser.
		[rssParser setShouldProcessNamespaces:NO];
		[rssParser setShouldReportNamespacePrefixes:NO];
		[rssParser setShouldResolveExternalEntities:NO];
		
		[rssParser parse];
	}
	@catch (NSException * e) {
		
		NSLog(@"Parsing error ");
	}
}

- (void)parser:(NSXMLParser *)parser parseErrorOccurred:(NSError *)parseError {
	NSLog(@"Parse Error ");
}

- (void)parser:(NSXMLParser *)parser didStartElement:(NSString *)elementName namespaceURI:(NSString *)namespaceURI qualifiedName:(NSString *)qName attributes:(NSDictionary *)attributeDict{			
    //NSLog(@"found this element: %@", elementName);
	NSString *tmpCurElement = [[NSString alloc] initWithString:elementName];
	[self setCurrentElement: tmpCurElement];
	[tmpCurElement release];
	tmpCurElement = nil;						   
							   
	if ([elementName isEqualToString:@"item"]) {
		// clear out our story item caches...
		NSMutableDictionary *tmpItem = [[NSMutableDictionary alloc] init];
		[self setItem: tmpItem];
		[tmpItem release];
		tmpItem = nil;
		
		NSMutableString *tmpCurrentTitle = [[NSMutableString alloc] init];
		[self setCurrentTitle:tmpCurrentTitle ];
		[tmpCurrentTitle release];
		tmpCurrentTitle = nil;
		
		NSMutableString *tmpCurCatID = [[NSMutableString alloc] init];
		[self setCurrentCategoryId: tmpCurCatID];
		[tmpCurCatID release];
		tmpCurCatID = nil;
							
		NSMutableString *tmpCurID = [[NSMutableString alloc] init];
		[self setCurrentId:tmpCurID];
		[tmpCurID release];
		tmpCurID = nil;
										   
		NSMutableString	*tmpCurPubDate =[[NSMutableString alloc] init];
		[self setCurrentPubDate: tmpCurPubDate];
		[tmpCurPubDate release];
		tmpCurPubDate = nil;
		
		NSMutableString	*tmpCurDescription =[[NSMutableString alloc] init];
		[self setCurrentDescription: tmpCurDescription];
		[tmpCurDescription release];
		tmpCurDescription = nil;
								
		NSMutableString	*tmpCurImgLink =[[NSMutableString alloc] init];								   
		[self setCurrentImgLink:tmpCurImgLink];
		[tmpCurImgLink release];
		tmpCurImgLink = nil;
		
	}
	
}

- (void)parser:(NSXMLParser *)parser didEndElement:(NSString *)elementName namespaceURI:(NSString *)namespaceURI qualifiedName:(NSString *)qName{     
	//NSLog(@"ended element: %@", elementName);
	if ([elementName isEqualToString:@"item"]) {
		
		[item setObject:currentTitle forKey:@"title"];
		[item setObject:currentCategoryId forKey:@"category"];
		
		
		[item setObject:currentId forKey:@"id"];
		
		[item setObject:currentPubDate forKey:@"pubDate"];
		[item setObject:currentDescription forKey:@"description"];
		[item setObject:currentImgLink forKey:@"image_link"];
		
		NSLog(@"Retain count before adding  %d", [stories retainCount]);
		id newItem = [item copy];
		[stories addObject:newItem];
		[newItem release];
		newItem = nil;
		NSLog(@"Retain count after adding  %d", [stories retainCount]);
		
	}
	
}

- (void)parser:(NSXMLParser *)parser foundCharacters:(NSString *)string{
	//NSLog(@"found characters: %@ %@", currentElement, string);
	
	NSString *tmpString = [[NSString alloc] initWithString:string];
	
	@try {
		
		// save the characters for the current item...
		if ([currentElement isEqualToString:@"title"]) {
			[currentTitle appendString:tmpString];
		} else if ([currentElement isEqualToString:@"category"]) {
			[currentCategoryId appendString:tmpString];
		} else if ([currentElement isEqualToString:@"id"]) {
			[currentId appendString:tmpString];
		} else if ([currentElement isEqualToString:@"pubDate"]) {
			[currentPubDate appendString:tmpString];
		} else if ([currentElement isEqualToString:@"description"]) {
			[currentDescription appendString:tmpString];
		} else if ([currentElement isEqualToString:@"imgicon"]) {
			[currentImgLink appendString:tmpString];
		}
		
		[tmpString release];
		tmpString = nil;
	}
	@catch (NSException * e) {
		
		if(tmpString != nil){
			[tmpString release];
			tmpString = nil;
		}
		
	}
	
}

- (void)parserDidEndDocument:(NSXMLParser *)parser {
	NSUserDefaults *prefs = [NSUserDefaults standardUserDefaults];
	NSLog(@"Retain count parserDidEndDocument: %d", [stories retainCount]);
	NSLog(@"%d", [stories count]);
	[prefs setObject:stories forKey:@"com.mycompany.newsRanklist"];
	[prefs synchronize];
	
}


- (void)dealloc {
	if(currentElement != nil){
		NSLog(@"1");
		[currentElement release];
		currentElement =nil;
	}
	if( rssParser!=nil){
		NSLog(@"2");
		[rssParser release];
		rssParser =nil;
	}
	if( stories!=nil){
		NSLog(@"3");
		NSLog(@"Retain count %d", [stories retainCount]);
		[stories release];
		stories =nil;
		NSLog(@"Retain count %d", [stories retainCount]);
	}
	if( item!=nil){
		NSLog(@"4");
		[item release];
		item = nil;
	}
	if( currentTitle!=nil){
		[currentTitle release];
		currentTitle = nil;
	}
	if( currentId!=nil){
		[currentId release];
		currentId = nil;
	}
	if( currentCategoryId!=nil){
		[currentCategoryId release];
		currentCategoryId = nil;
	}
	if( currentDescription!=nil){
		[currentDescription release];
		currentDescription = nil;
	}
	if( currentImgLink!=nil){
		[currentImgLink release];
		currentImgLink = nil;
	}
	
	if( currentPubDate!=nil){
		[currentPubDate release];
		currentPubDate = nil;
	}
	
	if( pageNumber!=nil){
		[pageNumber release];
		pageNumber = nil;
	}
	
	
	
	
	[super dealloc];
}

@end

Here is the last memory leak screenshot:
General Leak | Flickr - Photo Sharing!

Here is the strange point:

NSLog(@"Retain count before %d", [stories retainCount]);
		
		NSMutableArray *tmpStories = [[NSMutableArray alloc] init];
		
		[self setStories: tmpStories ];
		[tmpStories release];
		tmpStories = nil;
		
		NSLog(@"Retain count after %d", [stories retainCount]);

First retain count is o but if i don't set tmpStories to nil then the next retain count is 2.
and in dealloc if i don't set stories =nil; then the retain count of stories is still 1 even after release.

It is killing me.

Please....

[BrianSlick]

I wouldn't worry about that leak.

You cannot rely on retainCount.

[mramin05]

Originally Posted by BrianSlick

I wouldn't worry about that leak.

You cannot rely on retainCount.

Thanks a lot. I am going to the next step.

Thanks again for your time and help.

[mramin05]

Originally Posted by BrianSlick

I wouldn't worry about that leak.

You cannot rely on retainCount.

Hi,
Another problem related that. Please have a look on the code.

                        PostXMLParser *postXMLParser = [PostXMLParser new];
			[postXMLParser loadPostData];
			[self populateItemList:[postXMLParser getXMLData]];
                         // populateItemList is a private function to manupulate that data. That is seems to be ok.

HOw to release this "postXMLParser" object? as I can not alloc, init this PostXMLParser.

will it be autoreleased?

Thanks in advance.
-- Amin