problem with BOOLs

[sumosumo84]

@implementation Store

@synthesize storeScrollView;

- (void) viewWillAppear:(BOOL)animated {
	credits = [[NSUserDefaults standardUserDefaults] integerForKey:@"credits"];
	creditCount.text = [NSString stringWithFormat:@"you have %i credits", credits];
	NSLog(@"%i",credits);
	bGreenBG = [[NSUserDefaults standardUserDefaults] boolForKey:@"bGreenBG"];
	greenBGAp = [[NSUserDefaults standardUserDefaults] boolForKey:@"greenBGAp"];
	bBlueBG = [[NSUserDefaults standardUserDefaults] boolForKey:@"bBlueBG"];
	blueBGAp = [[NSUserDefaults standardUserDefaults] boolForKey:@"blueBGAp"];
	bRedBG = [[NSUserDefaults standardUserDefaults] boolForKey:@"bRedBG"];
	redBGAp = [[NSUserDefaults standardUserDefaults] boolForKey:@"redBGAp"];

	[self onOff];
}
	

- (IBAction) gotoMainMenu{
	
	[self dismissModalViewControllerAnimated:YES];
}

//green bg vvvv
- (IBAction) greenBG{
	
	if (bGreenBG != TRUE) {
		credits = [[NSUserDefaults standardUserDefaults] integerForKey:@"credits"];
		
		if (credits > 10) {
			
			credits = credits - 10;
			
			NSLog(@"credits are %i",credits);
			[[NSUserDefaults standardUserDefaults] setInteger:credits forKey:@"credits"];
			
			creditCount.text = [NSString stringWithFormat:@"you have %i credits", credits];
			bGreenBG = TRUE;
			[[NSUserDefaults standardUserDefaults] setBool:bGreenBG forKey:@"bGreenBG"];
		} else {
			[self.view addSubview:lowCreditWarning];
			lowCreditWarning.frame = CGRectMake(35.0, 105.0, lowCreditWarning.frame.size.width, lowCreditWarning.frame.size.height);
		}
	} 
}


//green bg ^^^

//blue bg vvvv
- (IBAction) blueBG{
	
	if (bBlueBG != TRUE) {
		credits = [[NSUserDefaults standardUserDefaults] integerForKey:@"credits"];
		
		if (credits > 100) {
			
			credits = credits - 100;
			
			NSLog(@"credits are %i",credits);
			[[NSUserDefaults standardUserDefaults] setInteger:credits forKey:@"credits"];
			
			creditCount.text = [NSString stringWithFormat:@"you have %i credits", credits];
			bBlueBG = TRUE;
			[[NSUserDefaults standardUserDefaults] setBool:bBlueBG forKey:@"bBlueBG"];
		} else {
			[self.view addSubview:lowCreditWarning];
			lowCreditWarning.frame = CGRectMake(35.0, 105.0, lowCreditWarning.frame.size.width, lowCreditWarning.frame.size.height);
		}
	} 
}


//blue bg ^^^

//red bg vvvv
- (IBAction) redBG{
	
	if (bRedBG != TRUE) {
		credits = [[NSUserDefaults standardUserDefaults] integerForKey:@"credits"];
		
		if (credits > 1000) {
			
			credits = credits - 1000;
			
			NSLog(@"credits are %i",credits);
			[[NSUserDefaults standardUserDefaults] setInteger:credits forKey:@"credits"];
			
			creditCount.text = [NSString stringWithFormat:@"you have %i credits", credits];
			bRedBG = TRUE;
			[[NSUserDefaults standardUserDefaults] setBool:bRedBG forKey:@"bRedBG"];
		} else {
			[self.view addSubview:lowCreditWarning];
			lowCreditWarning.frame = CGRectMake(35.0, 105.0, lowCreditWarning.frame.size.width, lowCreditWarning.frame.size.height);
		}
	} 
}

Basically these are items in a store.
these items depend on bColorBG being false if they have not bought it.

But it seams that as i make new items to the store and i go to it, they are already bought! (aka bColorBG is TRUE)

how can i make it so all of the bColorBG variables are false on first launch and untill they buy it?

[ekba89]

You are taking bool values from user defaults. So there is only one bool value not for every item in the store which means if you buy one item all items' bool values will be true. You should have item class which contains some attribute for controlling if the item sold.

[Bertrand21]

You should use YES & NO values for the bools.

[sumosumo84]

does changing TRUE to YES do anything?

basically i am just asking how can i set those BOOLs to false untill they are bought? because if i put bColorBG (when i say bColorBG i am just saying its one of the BOOLs i am using so it could mean bBlueBG or bGreenBG)

i heard somewhere that BOOLs at first are not set to anything so i will try

if (bGreenBG != 1 && bGreenBG != 0){
        bGreenBG = FALSE;
}

[RLScott]

BOOLs are just integers. When they appear all by themselves they take the logicial value of "true" if they are non-zero as an integer and "false" if they are zero. You should never compare one BOOL with another. That is because the number 2 and the number 3 are both "true" as BOOLs, but if you compare them, the comparison will say they are not the same (because 2 does not equal 3). Now as a matter of fact, the compiler normally establishes a standard value for TRUE or YES, and it is usually the number 1. But you should not count on it. It is risky programming. Instead try to use only logical operators when dealing with BOOLs, like &&, ||, and "!". Don't use == or !=. Instead of

bGreenBG != 1

You should say

!bGreenBG (meaning bGreenBG is false)

And instead of

bGreen != 0

You should say just

bGreenBG (meaning bGreenBG is true)