App crashes after switching views a number of times?!

[ChrisYates]

I always thought that the OS dealt with memory when it comes to using viewControllers.

At the moment I have 3 views, the first is of course loaded into the Navigation Controller at startup and I have a button which when tapped adds a subview, on the subview is another button and once tapped removes the subview and then allocates a viewController and pops this new view onto the stack. The new view has a back button and when tapped pops the view.

It all works fine until I continually tap from the subview to add the viewController and back again, eventually it crashes but I don't really know why. I am releasing my objects and as I said I thought the OS would deal with it if memory was getting low.

Here's my code when the subview button is tapped to allocate the viewController:

-(IBAction) twoPlayerButton :(id)sender
{
	newTimer = [NSTimer scheduledTimerWithTimeInterval:0.40  target:self selector:@selector(show2PlayerScreen) userInfo:nil repeats:NO];
	NSString *path = [[NSBundle mainBundle] pathForResource:@"ButtonPress" ofType:@"mp3"];
	AVAudioPlayer* theAudio=[[AVAudioPlayer alloc] initWithContentsOfURL:[NSURL fileURLWithPath:path] error:NULL];
    self.buttonPress = theAudio;
	[buttonPress play];
	[theAudio release];
	
	white2PlayerGameFlash.animationImages = [NSArray arrayWithObjects:  
											 [UIImage imageNamed:@"White2PlayerGame.png"],
											 [UIImage imageNamed:@"WhiteBG.png"],
											 [UIImage imageNamed:@"White2PlayerGame.png"],
											 [UIImage imageNamed:@"WhiteBG.png"],
											 [UIImage imageNamed:@"White2PlayerGame.png"],
											 nil];
	
	white2PlayerGameFlash.animationDuration = 0.35;
	white2PlayerGameFlash.animationRepeatCount = 1;
	[white2PlayerGameFlash startAnimating];
	
}

And this is the code which fires the timer and adds the viewController:

-(void) show2PlayerScreen
{

UINavigationController *navController = self.navigationController;

TwoPlayerGame *twoPlayerGame = [[TwoPlayerGame alloc] initWithNibName:@"TwoPlayerGame" bundle:Nil];;

[navController pushViewController:twoPlayerGame animated:NO];
[twoPlayerGame release];

Here's what the console is telling me:

2010-10-25 20:24:50.537 LightsOut[349:207] Received memory warning. Level=1
2010-10-25 20:25:06.883 LightsOut[349:207] Received memory warning. Level=1
2010-10-25 20:25:19.809 LightsOut[349:207] Received memory warning. Level=1
2010-10-25 20:25:21.534 LightsOut[349:207] Received memory warning. Level=1
2010-10-25 20:25:25.712 LightsOut[349:207] Received memory warning. Level=2
Program received signal:  “0”.

So as soon as it receives memory warning level 2 the app crashes. Can anyone advise me as to how I might resolve this or what I'm doing wrong? Thanks.

Oh I'm running this on the iPad, not sure if that is relevant!

[thomashw]

Where is the subview being removed?

[ChrisYates]

I'm removing it in viewDidDisappear.

[thomashw]

Can you show more of your code?

Also, what's the reasoning for the timer instead of just calling the method?

[ChrisYates]

Hey thomashw, the reason I'm going with a timer is I have 5 images which flash up before I wish to call the method.

Not sure which part of the code you're looking for but my .m file is quite long:

Here's the header file:

@interface OutViewController : UIViewController {
	IBOutlet UIImageView *largeBulb;
	IBOutlet UIImageView *largeBulb2;
	IBOutlet UIImageView *smallBulb;
	IBOutlet UIImageView *smallBulb2;
	IBOutlet UIImageView *whiteFlash;
	IBOutlet UIImageView *whiteFlash2;
	IBOutlet UIView *multiPlayerView;
	IBOutlet UIImageView *white2PlayerGameFlash;
	int myInt;
	
	NSTimer *myTimer;
	NSTimer *newTimer;
	NSTimer *fireTimers;
	
	AVAudioPlayer *staticSounds;
	AVAudioPlayer *scarySounds;
	AVAudioPlayer *buttonPress;	
	
}

@property (retain, nonatomic) AVAudioPlayer *staticSounds;
@property (retain, nonatomic) AVAudioPlayer *scarySounds;
@property (retain, nonatomic) AVAudioPlayer *buttonPress;

-(IBAction) singlePlayerButton :(id)sender;
-(IBAction) multiPlayerButton :(id)sender;
-(IBAction) instructionsButton :(id)sender;

-(IBAction) backButton :(id)sender;

-(IBAction) twoPlayerButton :(id)sender;


@end

Here's the end of the .m file:

- (void)viewWillAppear:(BOOL)animated
{
		
	[super viewWillAppear:YES];
	myInt = 2;
	NSLog(@"myInt %d", myInt);
	
}

- (void)viewWillDisappear:(BOOL)animated
{
	
	[super viewWillDisappear:YES];
	myInt = 1;
	NSLog(@"myInt %d", myInt);
	
}
- (void)viewDidDisappear:(BOOL)animated
{
	[multiPlayerView removeFromSuperview];
	scarySounds = nil;
	staticSounds = nil;
	buttonPress = nil;
	myTimer = nil;
	newTimer = nil;
	
}

- (void)viewDidUnload {
	
	// Release any retained subviews of the main view.
	// e.g. self.myOutlet = nil;
	
}

- (void)dealloc {
	[buttonPress release];
	[staticSounds release];
	[scarySounds release];
    [super dealloc];
}

[thomashw]

You should be invalidating/releasing your NSTimer's and releasing your UIImageView's.

[ChrisYates]

Thanks thomashw you made me look harder at my code, I wasn't deallocating an image view in my viewContoller, now I can tap my buttons until my heart is content without one single memory warning

[thomashw]

Glad you figured it out.

Forget about the outlets. I assumed you had them set as properties. I believe I'm still correct about the timers though.

[Bertrand21]

Originally Posted by thomashw

Glad you figured it out.

Forget about the outlets. I assumed you had them set as properties. I believe I'm still correct about the timers though.

Pretty sure the timers invalidate themselves when the repeat is set to NO.