help with removeFromSuperView condition

[vamsi.ac]

i want to remove subview corresponding to that function.

if function1 is called

add pin1

if function2 is called

add pin2

if function1 is called again

remove existing pin1 and add new pin1 //this is what i want

but it is removing both pin1 and pin2 and adding new pin1 ...


so this is exactly what i don't want.

-(void)addressLocWithVar1:(CGFloat ) x andVar2:(CGFloat )y {

     [[self tabBarController] setSelectedIndex:2];

     UIImageView *addPin=[UIImageView alloc];

     //remove if there are already pins on the view

     for (UIImageView *addPin in [imageView subviews]){

     [addPin removeFromSuperview];
                    //i am asking addPin object to remove from superview, but bot pin1 and addPin objects are getting removed.
     }

     

     //setting up the animation propertis for the pin

     [UIView beginAnimations:nil context:nil];

     [UIView setAnimationDelegate:self];

     [UIView setAnimationCurve:UIViewAnimationCurveEaseInOut];

     [UIView setAnimationDuration:0.5];

     //creatingt the rect holding pin

     CGRect pinRect = CGRectMake(x , y-100, 16, 34);

     addPin = [[UIImageView alloc] initWithFrame:pinRect];

     [addPin setImage:[UIImage imageNamed:@"redpin.png"]];

     addPin.frame = CGRectMake(x, y, 16, 34 );

     [scrollView scrollRectToVisible:CGRectMake(x-160 , y-183, 320, 367) animated:YES];

     [imageView addSubview:addPin];

     [UIView commitAnimations];

     [addPin release];

}

-(IBAction)Loc: (id) sender{

     UIImageView *pin1=[UIImageView alloc];


     

     //remove if there are already pins on the view

     for (UIImageView *pin1 in [imageView subviews]) {

          [pin1 removeFromSuperview];

     }

     //setting up the animation propertis for the pin

     [UIView beginAnimations:nil context:nil];

     [UIView setAnimationDelegate:self];

     [UIView setAnimationCurve:UIViewAnimationCurveEaseInOut];

     [UIView setAnimationDuration:0.5];

     //creating the rect holding pin

     CGRect pinRect = CGRectMake(appDel.X4 , appDel.Y4-100, 16, 34);

     pin1 = [[UIImageView alloc] initWithFrame:pinRect];

     [pin1 setImage:[UIImage imageNamed:@"darkpin.png"]];

     pin1.frame = CGRectMake(appDel.X4, appDel.Y4, 16, 34 );

     [scrollView scrollRectToVisible:CGRectMake(appDel.X4-160 , appDel.Y4-183, 320, 367) animated:YES];

     [imageView addSubview:pin1];

     [UIView commitAnimations];

     [pin1 release];

}

[bytor99999]

How about just holding a reference to each pin, then just call it on the instance variable.

so

[self.pin1 removeFromSuperview];
self.pin1 = nil;
[self.pin2 removeFromSuperview];
self.pin2 = nil;

if either pin is nil, then calling removeFromSuperview is just basically ignored, no errors.

When you add a pin subview make sure you assign the corresponding instance variable.

Mark

[vamsi.ac]

self.pin is not even structure or union error.

any other ideas?

[vamsi.ac]

i am using

for (addPin in [imageView subviews]){
		[addPin removeFromSuperview];
		
	}

but it is removing the other subviews which are on the superview

is there any method to remove only addPin image from its superview?

[devanshree.c]

Originally Posted by vamsi.ac

self.pin is not even structure or union error.

any other ideas?

try to tag those pin1 and pin2....
so call the required tagged pin when required as:
pin1.tag=1;
pin2.tag=2;


if(pin1.tag==1)
//do the neccessary
else
//blah blah blah