problem with containsObject in NSMutableArray

[racharambola5]

Hi everyone, I am trying to find if there is any object in the mutable array that matches with the object I pass. Please see the function below.

The name comes from table view controller, so the row that is tapped is saved into name and passed to this function. I am trying to check whether the name in the table view controller equals to the name coming from the database. Here name refers to firstName and lastName..That's the reason I am appending those strings.

Please help me..I am confused of how to do this..if u have any better approach please let me know..thanks a lot..I think its trying to compare the memory locations of the object (not sure though) but is there any way so that it compares exactly the name that I am passing..

-(NSMutableDictionary *)getSearchContacts:(NSString *)name
{
	//---retrieve rows--- 
	NSString *qsql =[[NSString stringWithFormat:@"SELECT * FROM CONTACTS WHERE last_name LIKE '%@",[name substringToIndex:1]]stringByAppendingString:@"%' GROUP BY sugar_id ORDER BY last_name"]; 
	NSString *sugar_id;
	NSString *first_name;
	NSString *last_name;
	NSMutableArray *searchContacts=[[NSMutableArray alloc] init];

	sqlite3_stmt *statement;
	if (searchContactName == nil) {
		searchContactName=[[NSString alloc]init];
	}
	if (sqlite3_prepare_v2( db, [qsql UTF8String], -1, &statement, nil) == SQLITE_OK) {
		while (sqlite3_step(statement) == SQLITE_ROW) { 
			sugar_id= [NSString stringWithUTF8String:(char *)sqlite3_column_text(statement, 1)];
			first_name = [NSString stringWithUTF8String:(char *)sqlite3_column_text(statement, 3)];
			last_name = [NSString stringWithUTF8String:(char *)sqlite3_column_text(statement, 4)];  
		
			if ([first_name isEqualToString:@"(null)"]) {
				last_name=[last_name stringByReplacingCharactersInRange:NSMakeRange(0,1) withString:[[last_name substringToIndex:1] uppercaseString]];
				searchContactName=[searchContactName stringByAppendingString:last_name];
				searchContactName=[searchContactName stringByAppendingString:@":"];
				searchContactName=[searchContactName stringByAppendingString:@","];

			}
			else {
				
				first_name=[first_name stringByReplacingCharactersInRange:NSMakeRange(0,1) withString:[[first_name substringToIndex:1] uppercaseString]];
				last_name=[last_name stringByReplacingCharactersInRange:NSMakeRange(0,1) withString:[[last_name substringToIndex:1] uppercaseString]];
				searchContactName=[searchContactName stringByAppendingString:last_name];
				searchContactName=[searchContactName stringByAppendingString:@":"];
				searchContactName=[searchContactName stringByAppendingString:first_name];
				searchContactName=[searchContactName stringByAppendingString:@","];

				
				//	str = [first_name stringByAppendingString:@" "];
				//	str = [str stringByAppendingString:last_name];
			}
			[searchContacts addObject:searchContactName];
			//first_name = nil;
			//last_name = nil;
 			if ([searchContacts containsObject:name]==YES) {
               searchSugarId=[[NSMutableDictionary alloc]initWithObjectsAndKeys:sugar_id,searchContactName,nil];
			}
			
		}
		//---deletes the compiled statement from memory--- 
		sqlite3_finalize(statement);
	} 
	return searchSugarId;
	
}

[screwtape]

I'm afraid I just can't figure out what you're trying to do here.

You are adding a name to the searchContacts dictionary, then testing name against it, and if so, you are setting the return value to be a new dictionary with that name.

Couldn't you just compare name and searchContactName? If you're trying to return a dictionary of sugar_ids and constact names, you'll fail, as you're overwriting searchSugarId dictionary each time you add a name.