Memory Leak Help?

[EthanK]

I've got a memory leak that seems to be coming from my parser each time I run it, and I'm having a hard time understanding the issue! The memory leak was found with the leak performance tool.

In the header:

NSMutableString * currentNodeContent;

Starting my xml parsing element:

//----------------------------------------------
// Starting an Element
//----------------------------------------------
-(void)parser:(NSXMLParser *)parser didStartElement:(NSString *)elementName namespaceURI:(NSString *)namespaceURI qualifiedName:(NSString *)qName attributes:(NSDictionary *)attributeDict {
	if(qName) {
		elementName = qName;
	}
	
        //Only init a string if we are on the right element to build it.
	if ([elementName isEqualToString:@"missionname"])
		currentNodeContent = [[NSMutableString alloc] init];

Here is what happens as we collect characters.

//----------------------------------------------
// Finding characters during parse
//----------------------------------------------
- (void)parser:(NSXMLParser *)parser foundCharacters:(NSString *)string
{
	
	[currentNodeContent appendString:string];
	
}

Here is the ending element, where we save the string off to a new one and then release the temp one.

//----------------------------------------------
// Ending Element
//----------------------------------------------
- (void)parser:(NSXMLParser *)parser didEndElement:(NSString *)elementName namespaceURI:(NSString *)namespaceURI qualifiedName:(NSString *)qName
{	
	if(qName) {
		elementName = qName;
	}
	
	if([elementName isEqualToString:@"missionname"]){
		missionData[totalMissions].Name = [[NSMutableString alloc] init];
		missionData[totalMissions].Name = [currentNodeContent mutableCopy];
		[currentNodeContent release];
		currentNodeContent = nil;
	}

Pretty much when I stack trace it lights up everything in the above if statement for missionname. Even the simple appendstring gets a warning. Any thoughts? Is there anything I'm obviously doing wrong?

[SoulRed12]

It's this part:

missionData[totalMissions].Name = [[NSMutableString alloc] init];
missionData[totalMissions].Name = [currentNodeContent mutableCopy];

In the first line, you're creating a new, blank mutable string and assining its address to the Name pointer, and in the second line, you're creating another mutable string that's a copy of currentNodeContent and assigning the address of THAT object to the same pointer. The first NSMutableString then gets lost in memory.

So get rid of that first line and you should be fine.

[EthanK]

Thanks a ton SoulRed, that fixed it. That makes a lot of sense looking at it now, not sure why I was thinking I needed to get a new memory alloc before I could copy. :-)

Sorry for the late reply, I was on a sabbatical since the op, really appreciate the help!