Using Variables in an alert box?

[snrbrn]

I am trying to make an alert box that pops up with a textbox's text as its message, but whenever i try, it never it just pops up with an empty alert.

Here is my code:

@synthesize label;

@synthesize textBox1;

@synthesize text;

- (IBAction)buttonClick {
	UIAlertView *someText = [[UIAlertView alloc] initWithTitle: @"Text from textbox1" message: text delegate: self cancelButtonTitle: @"OK" otherButtonTitles: nil];
	[someText show];
	[someText release];
	text = textBox1.text;
	label.text = text;
}

in this case, text is the variable with the textbox's information, but it never shows up. i was thinking maybe NSLog() was the way to fix this problem?

[BrianSlick]

Oh man. I think all noobs should be required to include this poll. I like it.

You aren't using your property correctly. See the link in my signature if you need clarification.

[HockeyHippo]

This is how I would do it:

-(IBAction)buttonClick{
			NSString *textbox = [NSString stringWithFormat:@"Enter your text here!"];
			UIAlertView *alert = [[UIAlertView alloc]initWithTitle:@"Title!" 
														   message:(@"%@",textbox)
														  delegate:self 
												 cancelButtonTitle:@"Done" 
												 otherButtonTitles:nil];
			[alert show];
			[alert release];
		}

I think that's what you wanted. You can change the text of textbox and it will change the message of the alert.

[BrianSlick]

Originally Posted by HockeyHippo

This is how I would do it:

NSString *textbox = [NSString stringWithFormat:@"Enter your text here!"];

Depends on what the situation is, but since the text is coming from a text field, it is already a string, so the stringWithFormat is unnecessary.

message:(@"%@",textbox)

If this is even valid code to begin with, you are again taking something that is already a string, and further formatting it again as a string. Unnecessary.

NSString *someText = [[self theTextField] text];

message:someText

That's all you need.

Or if you don't want the local variable:

message: [[self theTextField] text]

[HockeyHippo]

Originally Posted by BrianSlick

message:(@"%@",textbox)

If this is even valid code to begin with, you are again taking something that is already a string, and further formatting it again as a string. Unnecessary.

I think that's right, just using a string formater. I thought thats what he was asking for!

Anyways, my code builds and runs well :S

I guess I'm too noob to answer questions.

/goes home

[BrianSlick]

Originally Posted by HockeyHippo

I think that's right, just using a string formater.

Huh. I didn't know that would work just by itself. I assumed it had to be part of NSLog.

If the formatting is appropriate for the situation, that's fine. I just see a lot of people doing initWithFormat or stringWithFormat for plain strings. [...:@"%@", string]. It's already a string, it is still a string, the formatting didn't do anything except make a brand new string that is exactly the same as the old string.

[snrbrn]

Originally Posted by HockeyHippo

This is how I would do it:

-(IBAction)buttonClick{
			NSString *textbox = [NSString stringWithFormat:@"Enter your text here!"];
			UIAlertView *alert = [[UIAlertView alloc]initWithTitle:@"Title!" 
														   message:(@"%@",textbox)
														  delegate:self 
												 cancelButtonTitle:@"Done" 
												 otherButtonTitles:nil];
			[alert show];
			[alert release];
		}

I think that's what you wanted. You can change the text of textbox and it will change the message of the alert.

But when you declare the NSString *textbox = [NSString stringWithFormat:@"Enter text here!"]; wouldnt that just put "Enter text here" in the alert box?