Odd object types in my Array

[bytor99999]

I have search functionality on books, and I get 25 books at a time, even if the search criteria could be a total above 25. So I add a Get More button, the user selects to get the next 25.

I am also showing the books in a grid view.

So I am creating an NSMutableArray and putting in BookViewControllers or the GetMoreViewController. This array constitutes a row of books.

Anyway, for some reason when debugging, I will see other object types in this array and there shouldn't be. Funny thing is that will happen after hitting the get more button a few times. Meaning 25 books returned. Hit get more, get the next 25, hit get more, gets the next 25, hit get more, exception where there is an odd object type. Like once I saw an NSDictionary, in another I saw a CFXString or something like that.

NSMutableArray *bookViewControllers = [[[NSMutableArray alloc] init] autorelease];
    
    //Could there be a calculation problem here
    for (int i=0; i< numberOfColumns; i++) {
        if ([books count] > firstBook) {
            SingleBookInSearchViewController *bookSubView = [[SingleBookInSearchViewController alloc] initWithNibName:@"SingleBookInSearchView" bundle:nil];
            bookSubView.appContainerViewController = self.appContainerViewController;
            bookSubView.book = [books objectAtIndex:firstBook];
            [bookViewControllers addObject:bookSubView];
            [bookSubView release];
        } else  {
            if (stateHolder.currentMode < BOOK_MODE) {

                if (appContainerViewController.bookViewStateHolder.totalCountForSearch >
                    appContainerViewController.bookViewStateHolder.lastCountForSearch) {
                
                    // Need to add the GetMoreBooks
                    GetMoreBooksViewController *moreBooks = [[[GetMoreBooksViewController alloc] initWithNibName:@"GetMoreBooksView" bundle:nil] autorelease];
                    moreBooks.detailViewController = self;
                    [booksViewControllers addObject:moreBooks];
                    break;
                }
            }
        }
        firstBook++;
        
    }
    
    [cell setBooks:bookViewControllers];

Thanks

Mark

[BrianSlick]

You are over-releasing moreBooks.

[bytor99999]

Originally Posted by BrianSlick

You are over-releasing moreBooks.

Thanks Brian. But that actually wasn't there before, I added it to see if that fixed my problem. Which of course it didn't. Funny thing is the index in the array that should be the booksViewControllers is where I get odd object types, the getMoreViewController is always the last object in the array and correct.

This problem also seems to be a timing thing, If I debug where it stops on the get more adding to the array and I check to see the object types in the array, then play, then click the get more, and continue for as long as it should take to have this problem, it does not happen.

If I don't break on that line and let it run normally and the user scrolls fast, then clicks the Get more button, after a little bit it happens.

Mark

[BrianSlick]

Try posting the actual code you want help with then. Nothing like wasting time with a wild goose chase.

Symptoms sound like a memory problem. Something autoreleased, probably.

[bytor99999]

Originally Posted by BrianSlick

Try posting the actual code you want help with then. Nothing like wasting time with a wild goose chase.

Symptoms sound like a memory problem. Something autoreleased, probably.

That is the actual code. Just that one line removed. Sorry for that one line, I thought I had removed it there.

Mark

[BrianSlick]

Well, how about posting the entire method.

I'd also be curious about where/how "books" is set up.

[bytor99999]

Just cause you asked.

Here is the rest of the method, actually the code above, as the code previously posted is the bottom of the method

- (UITableViewCell *)tableView:(UITableView *)tableView cellForRowAtIndexPath:(NSIndexPath *)indexPath {
    
    static NSString *CellIdentifier = @"BookCell";
    
    BookCellView *cell = (BookCellView *)[self.bookTableView dequeueReusableCellWithIdentifier:CellIdentifier];
    
    if (cell == nil) {
        cell = [[[BookCellView alloc] initWithStyle:UITableViewCellStyleDefault reuseIdentifier:CellIdentifier] autorelease];
    }
    
    BookViewStateHolder *stateHolder = appContainerViewController.bookViewStateHolder;
    NSArray *books = [stateHolder getBooksForCurrentMode];
    
    int row = [indexPath row];
    int firstBook = numberOfColumns * row;

And the only line after the code first posted is

return cell;
}

books is populated from a WebService api call in which the apis are provided by a third party library, and I receive the collection. This apis is used by lots of people out there.

Unfortunately, I cannot be more specific as the app isn't released yet.

Anyway, I updated the way I "reload" the table data that is a bit cleaner and might have solved the issue.

Thanks Brian for all you help again.

Mark