How to not to make views stack on views? "Running out of memory"

[BrianSlick]

Leak:

self.audioPlayer = [[AVAudioPlayer alloc] initWithContentsOfURL:fileURL error:nil];

Leak:

self.audioPlayer2 = [[AVAudioPlayer alloc] initWithContentsOfURL:fileURL2 error:nil]

Questionable:

-(IBAction) stage_3 {
	//View Switch
	Stage_3 *screen = [[Stage_3 alloc] initWithNibName:nil bundle:nil];
	screen.modalTransitionStyle = UIModalTransitionStyleCrossDissolve;
	[self presentModalViewController:screen animated:YES];
	[screen release];
	//Audio-Make sure the audio is at the start of the stream.
	self.audioPlayer.currentTime = 0;
	
	[self.audioPlayer play];	
}

So you are going to a new view controller, but playing the music here in the old view controller? Why? Either make each view controller worry about its own music - and this would mean stopping the music in the old view controller when you go to the new one - or make a single, common audio player.

This is a good example of what I was talking about before. You are leaving these audio players alive, even though the view isn't on the screen. So, get rid of them, like I said all the way back in post #4.

[AdamSubach]

Originally Posted by BrianSlick

Leak:

self.audioPlayer = [[AVAudioPlayer alloc] initWithContentsOfURL:fileURL error:nil];

Leak:

self.audioPlayer2 = [[AVAudioPlayer alloc] initWithContentsOfURL:fileURL2 error:nil]

Questionable:

-(IBAction) stage_3 {
	//View Switch
	Stage_3 *screen = [[Stage_3 alloc] initWithNibName:nil bundle:nil];
	screen.modalTransitionStyle = UIModalTransitionStyleCrossDissolve;
	[self presentModalViewController:screen animated:YES];
	[screen release];
	//Audio-Make sure the audio is at the start of the stream.
	self.audioPlayer.currentTime = 0;
	
	[self.audioPlayer play];	
}

So you are going to a new view controller, but playing the music here in the old view controller? Why? Either make each view controller worry about its own music - and this would mean stopping the music in the old view controller when you go to the new one - or make a single, common audio player.

This is a good example of what I was talking about before. You are leaving these audio players alive, even though the view isn't on the screen. So, get rid of them, like I said all the way back in post #4.

How would I create a single audioPlayer? If you mean code a single audioplayer then #import them into the rest of my views?

"By the way thank you so much for all your help"

[BrianSlick]

You could either move it to your app delegate or create your own singleton class.

It really depends on what the music is supposed to do. If each view controller plays a different song, then you can leave it pretty much as it is. Just stop playing music in the old controller, and clear out the property. You can build a new player when you return to the old controller.

If you just have background music that plays the entire time no matter what the user does, then all you need is a single player, and that player should not be in a view controller.

[justdan0227]

Originally Posted by AdamSubach

Not that im seeing...

Check to be sure that the NIB you are loading has all of the controls still in it that you linked back to your header file. I found this the hard way after renaming a control in my H and then not relinking it in my NIB. The NIB would fail on load.