"format not a string literal and no format arguments" warning

[cye]

i get this warning "format not a string literal and no format" but it doesnt seem to have an effect on my app.

	NSString *string = [[NSString alloc]initWithFormat:firstPrice.text];

[flamingliquid]

The string with format indicates that a variable argument list (va_list) should be passed in as the argument. Formats are used to place variables into a string and the first variable in the list should be an NSString with the formats (%@, %f, %i, %x, etc.). In your case change it to:

NSString *string = [[NSString alloc] initWithFormat:@"%@", firstPrice.text];

Maybe you don't need a format:

NSString *string = [[NSString alloc] initWithString:firstPrice.text];

Or much more simple, and uses less memory:

NSString *string = firstPrice.text;

Basically you are getting the warning because the method is marked with __attribute__((format(__NSString__, 1, 2))), which makes the compiler know that the first argument should be a literal NSString (@""), and in your case it isn't.

[cye]

Originally Posted by flamingliquid

The string with format indicates that a variable argument list (va_list) should be passed in as the argument. Formats are used to place variables into a string and the first variable in the list should be an NSString with the formats (%@, %f, %i, %x, etc.). In your case change it to:

NSString *string = [[NSString alloc] initWithFormat:@"%@", firstPrice.text];

Maybe you don't need a format:

NSString *string = [[NSString alloc] initWithString:firstPrice.text];

Or much more simple, and uses less memory:

NSString *string = firstPrice.text;

thanks!