NSMutableArray Problems

[kapps11]

Hey guys -

So in this app that im working on, I have an NSMutableArray that holds different colors. And yet i find that the count of the array is changing at random times. Ex: I log the count when its first set, and its 5, but then when i need to compare it to something else, for some reason it is now 4. No calls have been made to the array in between those times. any ideas?

Thx

[BrianSlick]

Post some code.

[kapps11]

int color = arc4random() % 4;
	switch (color) {
		case 0:
			[self.sequenceArray addObject:[[UIColor redColor] retain]];
			break;
		case 1:
			[self.sequenceArray addObject:[[UIColor yellowColor] retain]];
			break;
		case 2:
			[self.sequenceArray addObject:[[UIColor greenColor]retain]];
			break;
		case 3:
			[self.sequenceArray addObject:[[UIColor blueColor] retain]];
			break;
		default:
			break;
	}

that adds a color to the sequence. So i log after that function and it counts as 5. Then I log the same statement later and it counts as 4. None of the other code sets anything in the array, just reads it to compare to numbers etc so idt its helpful Ex:

if ([[object.sequenceArray objectAtIndex:index] isEqual:[UIColor redColor]])

[BrianSlick]

This is going to take a while if you only post snippets. Post everything - logs, whatever - related to that array if you want any chance of figuring out the issue.

And you are leaking the color objects, btw.

[kapps11]

Well I thought that maybe the color objects were being released or something so I retained them. alright here u go:

- (IBAction)colorPushed:(UIButton *)sender {
	if (!gameOver) {
	if (player1move < [simon.sequenceArray count]) {
	switch (sender.tag) {
		case 1:
			if ([[simon.sequenceArray objectAtIndex:player1move] isEqual:[UIColor redColor]]) {
				NSLog(@"red correct");
				player1score++;
			}
			player1move++;
			break;
		case 2:
			if ([[simon.sequenceArray objectAtIndex:player1move] isEqual:[UIColor yellowColor]]) {
				NSLog(@"yellow correct");
				player1score++;
			}
			player1move++;
			break;
		case 3:
			if ([[simon.sequenceArray objectAtIndex:player1move] isEqual:[UIColor greenColor]]) {
				NSLog(@"green correct");
				player1score++;
			}
			player1move++;
			break;
		case 4:
			if ([[simon.sequenceArray objectAtIndex:player1move] isEqual:[UIColor blueColor]]) {
				NSLog(@"blue correct");
				player1score++;
			}
			player1move++;
			break;

		default:
			break;
	}
		if (player1score == [simon.sequenceArray count]) {
			if (!gameOver) {
			NSLog(@"Player 1 wins");
				winLabel.text = @"Player 1 Wins!";
			player1move = 0;
			player2move = 0;
			player1score = 0;
				player2score = 0;
				continueButton.hidden = NO;
			//[simon addStepToCurrentSequence];
				gameOver = YES;
				NSLog(@"Count %d", [simon.sequenceArray count]);
			}
			}
		}
	else {
		if (player2move >= [simon.sequenceArray count]) {
			self.continueButton.hidden = NO;
			winLabel.text = @"BOTH LOSE!";
		}
	}
	
	if (player2move < [simon.sequenceArray count]) {
		switch (sender.tag) {
			case 5:
				if ([[simon.sequenceArray objectAtIndex:player2move] isEqual:[UIColor redColor]]) {
					NSLog(@"red correct");
					player2score++;
				}
				player2move++;
				break;
			case 6:
				if ([[simon.sequenceArray objectAtIndex:player2move] isEqual:[UIColor yellowColor]]) {
					NSLog(@"yellow correct");
					player2score++;
				}
				player2move++;
				break;
			case 7:
				if ([[simon.sequenceArray objectAtIndex:player2move] isEqual:[UIColor greenColor]]) {
					NSLog(@"green correct");
					player2score++;
				}
				player2move++;
				break;
			case 8:
				if ([[simon.sequenceArray objectAtIndex:player2move] isEqual:[UIColor blueColor]]) {
					NSLog(@"blue correct");
					player2score++;
				}
				player2move++;
				break;
				
			default:
				NSLog(@"ERROR IN P2 SIWTCH");
				break;
		}
		if (player2score == [simon.sequenceArray count]) {
			if (!gameOver) {
			NSLog(@"Player 2 wins");
			winLabel.text = @"Player 2 Wins!";
			player1move = 0;
			player2move = 0;
			player1score = 0;
			player2score = 0;
				continueButton.hidden = NO;
				gameOver = YES;
				NSLog(@"Count %d", [simon.sequenceArray count]);
		}
		}
	}
	else {
		if (player1move  >= [simon.sequenceArray count]) {
			self.continueButton.hidden = NO;
			winLabel.text = @"BOTH LOSE!";
		}
	}

	NSLog(@"%d", player1move);
	NSLog(@"%d", player2move);
	}
}


- (IBAction)continueGame {
	gameOver = NO;
	winLabel.text = @"";
	[simon addStepToCurrentSequence];
	NSLog(@"Array Count %d", [simon.sequenceArray count]);
	NSLog(@"%@", simon.sequenceArray);
	
	[self viewDidLoad];
}

So basically theres 8 buttons, each with a different tag. that corresponds to a color. the simon object managaes the color array, and sets it using the code i posted earlier. Any ideas? In the logs, right after continueGame is called, it is logged as 5, but when its logged during the colorPushed function, its 4.

[BrianSlick]

Does this:

NSLog(@"%@", simon.sequenceArray);

...report what you expect? If so, add it to the other places where you log the count and see if you can figure out what is missing.

[kapps11]

Thx! I figured it out. really stupid mistake on my part - I called viewDidLoad after adding to the sequence, and in there it starts a new sequence. So It would be 5 then, but then go back to (which is the beginning/default) when it starts a new sequence. Thanks for your help!