4.0 Movie code working but call back does not :(

[rmatakajr]

Hey Guys having an issue here



I have this code working for the movie player on 4.0 OS


MPMoviePlayerController* theMovie=[[MPMoviePlayerController alloc] initWithContentURL:[NSURL URLWithString:escapedUrl]];
theMovie.view.frame = CGRectMake(0, 0, self.view.bounds.size.width, self.view.bounds.size.height);
[self.view addSubview:theMovie.view];
theMovie.controlStyle=MPMovieControlStyleFullscree n;

[theMovie play];


Im trying to stick in a notifier when the [done] button gets pressed


So i put in


//Register for the playback finished notification.
[[NSNotificationCenter defaultCenter] addObserver:self
selector:@selector(myMovieFinishedCallback
name:MPMoviePlayerPlaybackDidFinishNotification
object:theMovie];


Before


[theMovie play];


Well when i press thedone button its suppost to call


-(void)myMovieFinishedCallbackNSNotification*)aNo tification
{
[UIApplication sharedApplication].networkActivityIndicatorVisible = NO;
MPMoviePlayerController* theMovie=[aNotification object];
[[NSNotificationCenter defaultCenter] removeObserver:self
name:MPMoviePlayerPlaybackDidFinishNotification
object:theMovie];
[theMovie release];
[activityIndicator stopAnimating];
}


Well when i press done on the controller the movie dtops playing but the view does not close and return back tomy application

can someone help me figure this out please


Thank You

Ricky

[JasonR]

I don't see where you've added any code to close the view, so it just sits there. You probably want this line before you release:

[theMovie removeFromSuperview];

[rmatakajr]

Hey Thanks for your quick reply dude

		MPMoviePlayerController* theMovie=[[MPMoviePlayerController alloc] initWithContentURL:[NSURL URLWithString:escapedUrl]];
		theMovie.view.frame = CGRectMake(0, 0, self.view.bounds.size.width, self.view.bounds.size.height);
		[self.view addSubview:theMovie.view];
		theMovie.controlStyle=MPMovieControlStyleFullscreen;


		//Register for the playback finished notification. 
		[[NSNotificationCenter defaultCenter] addObserver:self 
											  selector:@selector(myMovieFinishedCallback:) 
											  name:MPMoviePlayerPlaybackDidFinishNotification 
											  object:theMovie];

Then I added what you told me

   [UIApplication sharedApplication].networkActivityIndicatorVisible = NO;
	MPMoviePlayerController* theMovie=[aNotification object]; 
    [[NSNotificationCenter defaultCenter] removeObserver:self 
										  name:MPMoviePlayerPlaybackDidFinishNotification 
										  object:theMovie];
	[theMovie removeFromSuperview]; // <----------
    [theMovie release]; 
	[activityIndicator stopAnimating];

First thing that happens is the audio starts to play then there is a deley before the controls display

Then when i press the done button the movie freezes and not returned to app

Any Ideas

Ricky

[JasonR]

Did you ignore a warning? That code should not have compiled with the typo. It should be

[theMovie.view removeFromSuperview];

I can't help you with the audio problem, I've never seen that before.

[rmatakajr]

WOW im a smuck.. thanks!! i guess im just to into the code to see the small thing... he he thanks a million!!

One more question, i have working code for 3.1.1 how do i do an if else to
detect the OS version?

Im real new to the iphone code and i have been winging it

Thanks
Ricky

[JasonR]

The idea is to test for the functionality instead of the OS version whenever possible. Since 3.2 and 4.0 have the option of playing full screen or not, here's code that detects that to decide which way to go:

     moviePlayer = [[MPMoviePlayerController  alloc] initWithContentURL:movieURL];

     if ([moviePlayer respondsToSelector:@selector(setFullscreen:animated:)]) {
          moviePlayer.shouldAutoplay = YES;
          [self.view addSubview:moviePlayer.view];
          [moviePlayer setFullscreen:YES animated:YES];
     }
     else {
          [moviePlayer play];
     }

[rmatakajr]

Awesome man! Thanks alot, im going to give that code a whirl tomorrow
really though thanks for all your help


Ricky

[rc20rd]

That is great.
The done button works
thanks