Out of memory

[iisword]

*** Assertion failure in +[Diary insertNewEntryIntoDiary:withString:withLocation:withDate:], /Users/iisword/Documents/Programs/TargetDiary/Classes/Diary.m:30
2010-03-16 10:49:51.346 TargetDiary[193:207] *** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'Error: failed to complete statment 'out of memory'.'
2010-03-16 10:49:51.347 TargetDiary[193:207] Stack: (
    30430299,
    2554115337,
    30514235,
    802580,
    12259,
    11576,
    16784,
    28837483,
    28833199,
    28808483,
    28826638,
    30214848,
    30211144,
    37713805,
    37714002,
    2789379,
    10364,
    10218
)

Thats the error I'm getting, what ways can I decrease my memory usage.

[smithdale87]

how many entries are you putting in the diary?

[iisword]

Originally Posted by smithdale87

how many entries are you putting in the diary?

3 items going into diary(each a string): entry, location, and date.

[iisword]

Here is the code I'm using

starts:

-(void)locationManager:(CLLocationManager *)manager 
   didUpdateToLocation:(CLLocation *)newLocation 
		  fromLocation:(CLLocation *)oldLocation
{
	NSLog(@"Setting Postition");
	self.currentPosition = newLocation;
	NSLog(@"Position Set");
	
	NSLog(@"Getting current date");
	NSDate *currentDate = [NSDate date];
	NSDateFormatter *format = [[NSDateFormatter alloc] init];
	[format setDateFormat:@"MMM dd, yyyy HH:mm"];
	NSString *dateString = [[NSString alloc] initWithString:[format stringFromDate:currentDate]];
	NSLog(@"Date Set");
	
	[format dealloc];
	
	float lat = currentPosition.coordinate.latitude; 
	float lon = currentPosition.coordinate.longitude;
	NSString *location;
	//test for east west south and north
	if (lat < 0 && lat < 0)
	{
		lat = -lat;
		lon = -lon;
		location = [[NSString alloc] initWithFormat:@"Latitude:%1.2f°S   Longitude:%1.2f°W", lat, lon];
	}
	else if (lat> 0 && lon > 0)
	{
		location = [[NSString alloc] initWithFormat:@"Latitude:%1.2f°N   Longitude:%1.2f°E", lat, lon];
	}
	else if (lon < 0 && lat > 0)
	{
		lon = -lon;
		location = [[NSString alloc] initWithFormat:@"Latitude:%1.2f°N   Longitude:%1.2f°W", lat, lon];
	}
	else
	{
		lat = -lat;
		location = [[NSString alloc] initWithFormat:@"Latitude:%1.2f°N   Longitude:%1.2f°E", lat, lon];
	}
	NSLog(location);
	NSLog(dateString);
	
	NSLog(@"Saving to database");
	[appDelegate setDiaryEntry:entry.text];
	[appDelegate setDateString:dateString];
	[appDelegate setLocation:location];
	[appDelegate addEntry];

	[save setHidden:NO];
	[active stopAnimating];
	[location dealloc];
	[dateString release];
	
}

goes to:

-(void)addEntry
{
	NSLog(@"Starting");
	NSInteger pk = [Diary insertNewEntryIntoDiary:diaryDatabase withString:diaryEntry withLocation:location withDate:dateString];
	Diary *newDiary = [[Diary alloc] initWithPrimaryKey:pk database:diaryDatabase];
		
	[diaries addObject:newDiary];
	NSLog(@"ended");
}

-(void)setDiaryEntry:(NSString *)newEntry
{
	diaryEntry = newEntry;
}

-(void)setDateString:(NSString *)newDate
{
	dateString = newDate;
}

-(void)setLocation:(NSString *)newLocation
{
	location = newLocation;
}

and finally
+(NSInteger)insertNewEntryIntoDiarysqlite3 *)diaryDatabase withStringNSString *)text withLocationNSString *)location withDateNSString *)date
{
NSLog(@"Method Started");
if (add_statement == nil)
{
static char *sql = "INSERT INTO diary(entry, location, date) VALUES (?,?,?)";
NSLog(@"sql created");
if (sqlite3_prepare_v2(diaryDatabase, sql, -1, &add_statement, NULL) != SQLITE_OK)
{
NSAssert1(0, @"Error: failed to complete statment '%s'.", sqlite3_errmsg(diaryDatabase));
}
}

sqlite3_bind_text(add_statement, 1, [text UTF8String], -1, SQLITE_TRANSIENT);
sqlite3_bind_text(add_statement, 2, [location UTF8String], -1, SQLITE_TRANSIENT);
sqlite3_bind_text(add_statement, 3, [date UTF8String], -1 , SQLITE_TRANSIENT);

int success = sqlite3_step(add_statement);
if (success != SQLITE_ERROR)
{
return sqlite3_last_insert_rowid(diaryDatabase);
NSLog(@"ended successfully");
}
else
{
NSAssert1(0, @"Error occured in insertNewEntry with message '%s'.", sqlite3_errmsg(diaryDatabase));
return -1;
}
}[/code]

[smasher]

You'll have to read more about retain, release, and properties. I see you doing things like this:

	//destroy the "location" string, even if someone else is using
	//or retaining it.
	[location dealloc];

You should not call "dealloc" yourself except [super dealloc] at the end of your own dealloc method. You should be calling [location release] here instead. Same with [format dealloc].

Your setDiaryEntry, setDateString, setLocation methods are also very dangerous because they don't retain the data you send them. It may work now because you call addEntry right away, but If you try to access those pointers later (after someone else releases these strings) they may be invalid.

The more correct way to write them would be:

-(void)setDiaryEntry:(NSString *)newEntry{

	// do nothing if pointer is to the same entry
	if (newEntry != diaryEntry){ 

		[diaryEntry release]; //release old entry
		diaryEntry = [newEntry retain]; //retain new entry

	}
}

A better and easier way to handle this would be to use properties; whatever book you're using should have chapters on retain, release, and properties.

[iisword]

Originally Posted by smasher

You'll have to read more about retain, release, and properties. I see you doing things like this:

	//destroy the "location" string, even if someone else is using
	//or retaining it.
	[location dealloc];

You should not call "dealloc" yourself except [super dealloc] at the end of your own dealloc method. You should be calling [location release] here instead. Same with [format dealloc].

Your setDiaryEntry, setDateString, setLocation methods are also very dangerous because they don't retain the data you send them. It may work now because you call addEntry right away, but If you try to access those pointers later (after someone else releases these strings) they may be invalid.

The more correct way to write them would be:

-(void)setDiaryEntry:(NSString *)newEntry{

	// do nothing if pointer is to the same entry
	if (newEntry != diaryEntry){ 

		[diaryEntry release]; //release old entry
		diaryEntry = [newEntry retain]; //retain new entry

	}
}

A better and easier way to handle this would be to use properties; whatever book you're using should have chapters on retain, release, and properties.

I'm noticing a leak from UITextView when the user clicks on it...

Also I changed the addEntry method to

addEntry:(NSString *) withLocation:(NSString *)withDate:(NSString *)

[smasher]

Originally Posted by iisword

I'm noticing a leak from UITextView when the user clicks on it...

Also I changed the addEntry method to

addEntry:(NSString *) withLocation:(NSString *)withDate:(NSString *)

You'll get a leak if you're retaining something and not releasing it when you're done with it. If you used the setDiaryEntry that I wrote above, or you used a property, then you should release newEntry in the dealloc method for that class.

[iisword]

I got rid of my set methods and tried using this way:

NSLog(@"Setting Postition");
	self.currentPosition = newLocation;
	NSLog(@"Position Set");
	
	NSLog(@"Getting current date");
	NSDate *currentDate = [NSDate date];
	NSDateFormatter *format = [[NSDateFormatter alloc] init];
	[format setDateFormat:@"MMM dd, yyyy HH:mm"];
	NSString *dateString = [[NSString alloc] initWithString:[format stringFromDate:currentDate]];
	NSLog(@"Date Set");
	
	NSString *entryString = [[NSString alloc] initWithString:entry.text];
	
	[entry release];
	[format release];
	[currentDate release];
	
	float lat = currentPosition.coordinate.latitude; 
	float lon = currentPosition.coordinate.longitude;
	NSString *location;
	
	if (lat < 0 && lat < 0)
	{
		lat = -lat;
		lon = -lon;
		location = [[NSString alloc] initWithFormat:@"Latitude:%1.2f°S   Longitude:%1.2f°W", lat, lon];
	}
	else if (lat> 0 && lon > 0)
	{
		location = [[NSString alloc] initWithFormat:@"Latitude:%1.2f°N   Longitude:%1.2f°E", lat, lon];
	}
	else if (lon < 0 && lat > 0)
	{
		lon = -lon;
		location = [[NSString alloc] initWithFormat:@"Latitude:%1.2f°N   Longitude:%1.2f°W", lat, lon];
	}
	else
	{
		lat = -lat;
		location = [[NSString alloc] initWithFormat:@"Latitude:%1.2f°N   Longitude:%1.2f°E", lat, lon];
	}
	NSLog(location);
	NSLog(dateString);
	
	NSLog(@"Saving to database");
	[appDelegate addEntry:entryString withLocation:location withDate:dateString];

	[save setHidden:NO];
	[active stopAnimating];
	[location release];
	[dateString release];
	[entryString release];

still getting the same error