Memory Leak in AdressBook: What works in Simulator crashes on Device

[StefanL]

Hi Folks,

in my app I am reading the contacts of the adressbook into a NSMutableArray:

ABAddressBookRef addressBook = ABAddressBookCreate();
	
	CFArrayRef allPeople = ABAddressBookCopyArrayOfAllPeople(addressBook);
	CFIndex nPeople = ABAddressBookGetPersonCount(addressBook);
	
	masterList = [[NSMutableArray alloc] init];
	userID = [[NSMutableArray alloc] init];
	
	for (int i = 0; i < nPeople; i++) {
		ABRecordRef ref = CFArrayGetValueAtIndex(allPeople, i);
		CFStringRef firstName = ABRecordCopyValue(ref, kABPersonFirstNameProperty);
		CFStringRef lastName = ABRecordCopyValue(ref, kABPersonLastNameProperty);
		NSNumber *recordId = [NSNumber numberWithInteger: ABRecordGetRecordID(ref)];
		addId = [NSString stringWithFormat:@"%d", (NSNumber *)recordId];
		NSString *contactFirstLast = [NSString stringWithFormat: @"%@, %@",(NSString *)lastName, (NSString *)firstName];
		NSString *userId = [NSString stringWithFormat:@"%@, %@, %@", (NSString *)lastName, (NSString *)firstName, (NSNumber *)recordId];
		CFRelease(firstName);
		CFRelease(lastName);
		
		

		
		
		[masterList addObject:contactFirstLast];
		[userID addObject:userId];
		
		NSLog(@"masterlist: %@", masterList);
		NSLog(@"ID = %d", userID);
	//	[contactFirstLast release];
	}

This is perfectly working in the simulator, but when I am installing the app on my testphone it is crashing...

target remote-mobile /tmp/.XcodeGDBRemote-3659-49
Switching to remote-macosx protocol
mem 0x1000 0x3fffffff cache
mem 0x40000000 0xffffffff none
mem 0x00000000 0x0fff none
run
Running…
[Switching to thread 11779]
[Switching to thread 11779]
(gdb) continue
Program received signal: “EXC_BAD_ACCESS”.
kill
quit

When I comment out the code above everything is working fine! Do I have a memory leak? Do I have to Release the Number (NSNumber *)recordId?

Thanks for any help!

Stefan

[harrytheshark]

You shouldn't be releasing "contactFirstLast". You don't own the object.
Take a look at the memory management docs if you haven't already.

[lukeca]

I ran into some issues like this too, I think you need to check that firstName and lastName exist before you try to use them, or any other field that you pull from the address. On the simulator the address book has all perfect data where every field is filled in, but on your device you might have entries that don't have a last name or something like that.

So something like this: (This is just an example, because this will ignore any entries that do not have both a first and last name)

ABAddressBookRef addressBook = ABAddressBookCreate();
	
	CFArrayRef allPeople = ABAddressBookCopyArrayOfAllPeople(addressBook);
	CFIndex nPeople = ABAddressBookGetPersonCount(addressBook);
	
	masterList = [[NSMutableArray alloc] init];
	userID = [[NSMutableArray alloc] init];
	
	for (int i = 0; i < nPeople; i++) {
		ABRecordRef ref = CFArrayGetValueAtIndex(allPeople, i);
		CFStringRef firstName = ABRecordCopyValue(ref, kABPersonFirstNameProperty);
		CFStringRef lastName = ABRecordCopyValue(ref, kABPersonLastNameProperty);
		NSNumber *recordId = [NSNumber numberWithInteger: ABRecordGetRecordID(ref)];
		addId = [NSString stringWithFormat:@"%d", (NSNumber *)recordId];

//New Code
if ((firstName) && (lastName)) {
NSString *contactFirstLast = [NSString stringWithFormat: @"%@, %@",(NSString *)lastName, (NSString *)firstName];
NSString *userId = [NSString stringWithFormat:@"%@, %@, %@", (NSString *)lastName, (NSString *)firstName, (NSNumber *)recordId];
}
		CFRelease(firstName);
		CFRelease(lastName);
		
		

		
		
		[masterList addObject:contactFirstLast];
		[userID addObject:userId];
		
		NSLog(@"masterlist: %@", masterList);
		NSLog(@"ID = %d", userID);
	//	[contactFirstLast release];
	}

[StefanL]

Hi Folks,

thanks for your help and assistance!

@harry: I have not releasing the [contactfirstlast] - I have commented it out :-)

@lukeca: You were completely right! I have adapted the code like the following

	ABAddressBookRef addressBook = ABAddressBookCreate();
	
	if (!addressBook)   
	{  
		NSLog(@"opening address book");  
	}  
	
	CFArrayRef allPeople = ABAddressBookCopyArrayOfAllPeople(addressBook);
	CFIndex nPeople = ABAddressBookGetPersonCount(addressBook);
	
	for (int i = 0; i < nPeople; i++) {
		ABRecordRef ref = CFArrayGetValueAtIndex(allPeople, i);
		CFStringRef firstName = ABRecordCopyValue(ref, kABPersonFirstNameProperty);
		CFStringRef lastName = ABRecordCopyValue(ref, kABPersonLastNameProperty);
		NSNumber *recordId = [NSNumber numberWithInteger: ABRecordGetRecordID(ref)];
		addId = [NSString stringWithFormat:@"%d", (NSNumber *)recordId];
		//New Code
		if ((lastName) && (firstName)) {
			contactFirstLast = [NSString stringWithFormat: @"%@, %@",(NSString *)lastName, (NSString *)firstName];
			userId = [NSString stringWithFormat:@"%@, %@, %@", (NSString *)lastName, (NSString *)firstName, (NSNumber *)recordId];
		} else {
		
			NSLog(@"bingo");
		
		}
		CFRelease(firstName);
		CFRelease(lastName);
		CFRelease(ref); 
		
		

		
		
		[masterList addObject:contactFirstLast];
		[userID addObject:userId];
		
		NSLog(@"masterlist: %@", masterList);
		NSLog(@"ID = %@", userID);
	}

But I am not sure what can I do to show the Names even if I have only the first or the lastname (at least one of them should be in the addressbook)... Thanks for your help!

BR,

Stefan