Help With Multiple Text Field Valdiation

zacharyrs · 01-12-2010, 01:05 PM

I have five fields I need to validate, as different fields require a different range of numbers to have input by the user. The idea is when the user clicks to the next field it checks the previous field, however this isn't how it's working

Is there a better way in my code to do this? I'd also like it when the user hits wrong info and disregards the error messages, it doesn't allow them to go to the next field.

Below is my code:

Code:

- (void)textFieldDidEndEditing:(UITextField *)textField
{	
	//NSLog(@"BundlePath: %@", [[NSBundle mainBundle] bundlePath]);
	
	//declare the vars
	NSString *userNameOne = txtUserName.text;
	float numOne = [userNameOne intValue];			//age in years
	NSString *userNameTwo = txtUserName2.text;
	float numTwo = [userNameTwo intValue];			//iop
	NSString *userNameThree = txtUserName3.text;
	float numThree = [userNameThree intValue];		//cct
	NSString *userNameFour = txtUserName4.text;	
	float numFour = [userNameFour intValue];		//psd
	NSString *userNameFive = txtUserName5.text;
	float numFive = [userNameFive intValue];

	
	if(numOne < 40 || numOne > 100)
	{
			
		//play sound and vibrate for alert
		NSString *bonkSoundFile = [[NSBundle mainBundle] pathForResource:@"alertSound" ofType:@"mp3"];
		NSURL *fileURL = [NSURL fileURLWithPath:bonkSoundFile];
		SystemSoundID  bonkSoundID;
		AudioServicesCreateSystemSoundID( (CFURLRef) fileURL, &bonkSoundID);
		AudioServicesPlaySystemSound(bonkSoundID);
		AudioServicesPlaySystemSound (kSystemSoundID_Vibrate);	//vibrate
		
		//show alert
		UIAlertView *alert = [[UIAlertView alloc]
							  initWithTitle:@"Age Error"
							  message:@"Your age must be at least 40 years old and less than 100 years old"
							  delegate:nil
							  cancelButtonTitle:@"OK"
							  otherButtonTitles:nil];
		[alert show];
		[alert release];
	}
	
	else if (numTwo < 20 || numTwo > 32)
	{
		UIAlertView *alert = [[UIAlertView alloc]
							  initWithTitle:@"IOP Error"
							  message:@"Your IOP must be between 20 and 32"
							  delegate:nil
							  cancelButtonTitle:@"OK"
							  otherButtonTitles:nil];
		[alert show];
		[alert release];
	}
	
	else if (numThree < 475 || numThree > 650)
	{
		UIAlertView *alert = [[UIAlertView alloc]
							  initWithTitle:@"CCT Error"
							  message:@"Your CCT must be between 475 and 650"
							  delegate:nil
							  cancelButtonTitle:@"OK"
							  otherButtonTitles:nil];
		[alert show];
		[alert release];
	}
	
	else if (numFour < .50 || numFour > 3.00)
	{
		UIAlertView *alert = [[UIAlertView alloc]
							  initWithTitle:@"PSD Error"
							  message:@"Your PSD must be between .50 and 3.00"
							  delegate:nil
							  cancelButtonTitle:@"OK"
							  otherButtonTitles:nil];
		[alert show];
		[alert release];
	}
	
	else if (numFive < 0.80)
	{
		UIAlertView *alert = [[UIAlertView alloc]
							  initWithTitle:@"C/D Error"
							  message:@"Your C/D must be between 0 and .80"
							  delegate:nil
							  cancelButtonTitle:@"OK"
							  otherButtonTitles:nil];
		[alert show];
		[alert release];
	}
}

And you can see a video of how it works (rather buggy)
2010-01-12_1258

Any advice would be greatly appreciated!

itzdark · 01-12-2010, 01:24 PM

instead of one big if else if statement split them up and only validate them if the associated textfield ended editing if(textField==txtUserName)

zacharyrs · 01-12-2010, 05:08 PM

Quote:

Originally Posted by itzdark

instead of one big if else if statement split them up and only validate them if the associated textfield ended editing if(textField==txtUserName)

Yes! Great point! I have updated the code as seen below. Any way to modify this so that if the user doesn't input correct amount, it won't go to next field or allow the option to hit next?

Code:

- (void)textFieldDidEndEditing:(UITextField *)textField
{	
	
	if (textField == txtUserName)
	{
		NSString *userNameOne = txtUserName.text;
		double numOne = [userNameOne intValue];	

			if(numOne < 40 || numOne > 100)
			{
			
				//play sound and vibrate for alert
				NSString *bonkSoundFile = [[NSBundle mainBundle] pathForResource:@"alertSound" ofType:@"mp3"];
				NSURL *fileURL = [NSURL fileURLWithPath:bonkSoundFile];
				SystemSoundID  bonkSoundID;
				AudioServicesCreateSystemSoundID( (CFURLRef) fileURL, &bonkSoundID);
				AudioServicesPlaySystemSound(bonkSoundID);
				AudioServicesPlaySystemSound (kSystemSoundID_Vibrate);	//vibrate
		
				//show alert
				UIAlertView *alert = [[UIAlertView alloc]
							  initWithTitle:@"Age Error"
							  message:@"Your age must be at least 40 years old and less than 100 years old"
							  delegate:nil
							  cancelButtonTitle:@"OK"
							  otherButtonTitles:nil];
				[alert show];
				[alert release];
			}
		}
	
	else if (textField == txtUserName2)
	{
		NSString *userNameThree = txtUserName2.text;
		float numTwo = [userNameThree intValue];	
			
		if (numTwo < 20 || numTwo > 32)
		{
			UIAlertView *alert = [[UIAlertView alloc]
							  initWithTitle:@"IOP Error"
							  message:@"Your IOP must be between 20 and 32"
							  delegate:nil
							  cancelButtonTitle:@"OK"
							  otherButtonTitles:nil];
			[alert show];
			[alert release];
		}
	}
	
	else if (textField == txtUserName3)
	{
		NSString *userNameThree = txtUserName3.text;
		float numThree = [userNameThree intValue];
		
		if (numThree < 475 || numThree > 650)
		{
		
			UIAlertView *alert = [[UIAlertView alloc]
							  initWithTitle:@"CCT Error"
							  message:@"Your CCT must be between 475 and 650"
							  delegate:nil
							  cancelButtonTitle:@"OK"
							  otherButtonTitles:nil];
			[alert show];
			[alert release];
		}
	}
	
	else if (textField == txtUserName4)
	{
		NSString *userNameFour = txtUserName4.text;	
		float numFour = [userNameFour intValue];
		
		if (numFour < .50 || numFour > 3.00)
		{
		
			UIAlertView *alert = [[UIAlertView alloc]
							  initWithTitle:@"PSD Error"
							  message:@"Your PSD must be between .50 and 3.00"
							  delegate:nil
							  cancelButtonTitle:@"OK"
							  otherButtonTitles:nil];
			[alert show];
			[alert release];
		}
	}
	
	else if (textField == txtUserName5)
	{
		NSString *userNameFive = txtUserName5.text;
		float numFive = [userNameFive intValue];

		if (numFive < 0.80)
		{
			
			UIAlertView *alert = [[UIAlertView alloc]
							  initWithTitle:@"C/D Error"
							  message:@"Your C/D must be between 0 and .80"
							  delegate:nil
							  cancelButtonTitle:@"OK"
							  otherButtonTitles:nil];
			[alert show];
			[alert release];
		}
	}
}

glennmd · 09-11-2011, 08:20 PM

6 fields"

t1.text
t2.text
t3.text
diam1.text
diam2.text
dial3.text

t1,2,3 must have string of 8 to be later formatted as date i.e. mm/dd/yy

diam1,2,3 must not be zero

Here is the code using Apple's tag method. Note other simple methods will get repeated calls to the Alert that are unacceptable.

/////Start here//////////////Here Goes://////////////////////
//
// AViewController.m
// A
//
// Created by Glenn Tisman on 8/29/11.
// Copyright 2011 Glenn Tisman, M.D. Inc. All rights reserved.
//

#import "AViewController.h"

@implementation AViewController
@synthesize t1;
@synthesize t2;
@synthesize t3;
@synthesize diam1;
@synthesize diam2;
@synthesize diam3;
@synthesize TVDT;
@synthesize SGR;
@synthesize V0;
@synthesize V1;
@synthesize Vrx;
@synthesize VP;
@synthesize RxResponse;
@synthesize t2t1;
@synthesize t3t1;

/////////////////////////////////////////////////////////////////////////

enum {
t1Tag = 0,
t2Tag,
t3Tag,
diam1Tag,
diam2Tag,
diam3Tag,
};//you must go to assign each field manually through the UIView (find that by clicking on the field to tag and checking the UIView for the place to assign each field with a Tag number. //I suspect that this will work with the : -(BOOL) textFieldShouldEndEditing but I have not tried that.

-(void) textFieldDidEndEditing

UITextField *)textField {

switch (textField.tag) {
case 0:
if ([t1.text length] !=8){
UIAlertView *alert = [[UIAlertView alloc] initWithTitle:@"Yikes" message:@"Check date one"delegate:nil cancelButtonTitle:@"OK" otherButtonTitles: nil];
[alert show];
[alert release];
}
break;
case 1:
if ([t2.text length] !=8){
UIAlertView *alert = [[UIAlertView alloc] initWithTitle:@"Yikes" message:@"Check date two!"delegate:nil cancelButtonTitle:@"OK" otherButtonTitles: nil];
[alert show];
[alert release];
}
break;
case 2:
if ([t3.text length] !=8){
UIAlertView *alert = [[UIAlertView alloc] initWithTitle:@"Yikes" message:@"Check date three!"delegate:nil cancelButtonTitle:@"OK" otherButtonTitles: nil];
[alert show];
[alert release];
}
break;

case 3:
if ([diam1.text length] ==0){
UIAlertView *alert = [[UIAlertView alloc] initWithTitle:@"Yikes" message:@"Diameter at diagnosis is blank"delegate:nil cancelButtonTitle:@"OK" otherButtonTitles: nil];
[alert show];
[alert release];
}
break;
case 4:
if ([diam2.text length] ==0){
UIAlertView *alert = [[UIAlertView alloc] initWithTitle:@"Yikes" message:@"Diameter at start of Rx is blank"delegate:nil cancelButtonTitle:@"OK" otherButtonTitles: nil];
[alert show];
[alert release];
}
break;
case 5:
if ([diam3.text length] ==0){
UIAlertView *alert = [[UIAlertView alloc] initWithTitle:@"Yikes" message:@"Diameter post Rx is blank"delegate:nil cancelButtonTitle:@"OK" otherButtonTitles: nil];
[alert show];
[alert release];
}
break;

}