Help with saving score UIlabel

[jbullfrog]

I have two labels, one that shows current level another that shows high level. The current level label is updated each time you beat the computer.

current_level_value++;

For the high level lable I want to do a check to see if the current level labels value is larger than the high level label value, and if so save and update the high level label value. Anb also do this when the user clickes the home button.

ViewController.h

@interface ViewController : UIViewController {
	
	
        IBOutlet UILabel *current_level;
	IBOutlet UILabel *high_level;

	NSInteger current_level_value;
	NSInteger high_level_value;
}

@property(nonatomic,retain) IBOutlet UILabel *current_level;
@property(nonatomic,retain) IBOutlet UILabel *high_level;

@end

I have this code in my ViewController.m

-(void)reset:(BOOL) newGame {

if(computer_score == kScoreToWin) {

// computer wins do stuff
			
		} 
		else {
//you win
			current_level_value++;	
			
		}
		
	} 

	current_level.text = [NSString stringWithFormat:@"%d",current_level_value];
}




- (void)viewDidLoad {

current_level_value = 0;

	high_level.text = [NSString stringWithFormat:@"%d",high_level_value];

	//CHECK THEN LOAD HIGH LEVEL LOADER
			if(current_level > high_level) {
				high_level.text = [[NSUserDefaults standardUserDefaults] objectForKey:@"high_score"];
			}

	//SAVE HIGH LEVEL
	
	[[NSUserDefaults standardUserDefaults] setInteger:high_level_value forKey:@"high_score"];
	[[NSUserDefaults standardUserDefaults] synchronize];
		
[super viewDidLoad];
}

I'm not getting any errors or crashes, the current level label value is updating just fine, but when I quit and reopen the app the high level label value is still at zero.

Any thoughts?
Thanks

Originally Posted by smasher

It's probably better to start a new thread if you have a new question. Your "if" statement is bad - current_level and high_level are pointers (memory addresses,) so comparing them will not give you what you want. You should be comparing something else instead, like [current_level.text intValue] > [high_level.text intValue] .

Also it looks like you're doing the loading and saving in
viewDidLoad? Don't you need to save when the game is over, not when it's starting?

Thanks Smasher,

I was able to do the check, current level to high level, and it updates high level after the level ends but only durring your game session.

I used this code to do that.

		//COMPARE CURRENT LEVEL WITH HIGH LEVEL
		if([current_level.text intValue] > [high_level.text intValue]){
			
			high_level.text = current_level.text;

		}

But i cant seem to get the high level to save and load in when you quit and restart.

I tried to place this in the view did load, and nothing.

 //SAVE HIGH LEVEL
//[[NSUserDefaults standardUserDefaults] setInteger:high_level_value forKey:@"high_score"];
			//[[NSUserDefaults standardUserDefaults] synchronize];

And i cant seem to add it to my AppDelegate.m in the code below, because "high_level_value" isnt being implemented ther, its in my ViewController.m

- (void)applicationDidFinishLaunching:(UIApplication *)application {
//[[NSUserDefaults standardUserDefaults] setInteger:high_level_value forKey:@"high_score"];
			//[[NSUserDefaults standardUserDefaults] synchronize];
}

As you can tell im fairly new to this, ive looked around but cant seem to wrap my head around it. Any help would be appreciated, thanks.

[smasher]

Do you have a pointer to your controller in your appdelegate? Then you can put the "save score" stuff in a method in the controller, and call [myController saveScore] from applicationWillTerminate.

If not, you can register your controller to get applicationWillTerminate messages with code like this in viewDidLoad:

	[[NSNotificationCenter defaultCenter] addObserver: self selector: @selector(saveScore) name:UIApplicationWillTerminateNotification object:nil];

You don't want to save the score in applicationDidFinishLaunching - that's when the application is starting, not ending.

[jbullfrog]

Originally Posted by smasher

Do you have a pointer to your controller in your appdelegate? Then you can put the "save score" stuff in a method in the controller, and call [myController saveScore] from applicationWillTerminate.

If not, you can register your controller to get applicationWillTerminate messages with code like this in viewDidLoad:

	[[NSNotificationCenter defaultCenter] addObserver: self selector: @selector(saveScore) name:UIApplicationWillTerminateNotification object:nil];

You don't want to save the score in applicationDidFinishLaunching - that's when the application is starting, not ending.

Im not sure I Do you have a pointer to my controller in my appdelegate, I do have this

#import "testViewController.h"

Also I tried to place this code in the viewDidLoad, but didnt seem to do anything.

- (void)viewDidLoad {

	//high_level.text = [[NSUserDefaults standardUserDefaults] objectForKey:@"high_score"];
	[[NSNotificationCenter defaultCenter] addObserver: self selector: @selector(high_level) name:UIApplicationWillTerminateNotification object:nil];
	
	
	//[[NSUserDefaults standardUserDefaults] setInteger:high_level_value forKey:@"high_score"];
	//[[NSUserDefaults standardUserDefaults] synchronize];
	 
	//high_level = [NSString stringWithFormat:@"high_score"];
}

Is there a place that I can check to see if anything is being written to it?
If so I could check and maybe I'm just not retrieving it properly.

So far Im not having any lucj saving this darn number and retrieving it later.

[kohjingyu]

You'd want to do this:

- (void)viewDidLoad
{
       //Load data here

	UIApplication *app = [UIApplication sharedApplication];
	[[NSNotificationCenter defaultCenter] addObserver:self
											 selector:@selector(applicationWillTerminate:)
												 name:UIApplicationWillTerminateNotification
											   object:app];
	
    [super viewDidLoad];
}

- (void)applicationWillTerminate:(NSNotification *)notification
{
       //Save data here
}

Hope that helps.

[jbullfrog]

Originally Posted by kohjingyu

You'd want to do this:

- (void)viewDidLoad
{
       //Load data here

	UIApplication *app = [UIApplication sharedApplication];
	[[NSNotificationCenter defaultCenter] addObserver:self
											 selector:@selector(applicationWillTerminate:)
												 name:UIApplicationWillTerminateNotification
											   object:app];
	
    [super viewDidLoad];
}

- (void)applicationWillTerminate:(NSNotification *)notification
{
       //Save data here
}

Hope that helps.

I tried this and I don't get any errors or crashes, but it doesnt seem to save the high score label and load it back in when quit and reopened. What am i doing wrong here?

- (void)viewDidLoad
{
       //Load data here
if ([[NSUserDefaults standardUserDefaults] integerForKey:@"high_score"]) {
		high_level_value=[[NSUserDefaults standardUserDefaults] integerForKey:@"high_score"];

	UIApplication *app = [UIApplication sharedApplication];
	[[NSNotificationCenter defaultCenter] addObserver:self
											 selector:@selector(applicationWillTerminate:)
												 name:UIApplicationWillTerminateNotification
											   object:app];
	
    [super viewDidLoad];
}

- (void)applicationWillTerminate:(NSNotification *)notification
{
       //Save data here
[[NSUserDefaults standardUserDefaults] setInteger:high_level_value forKey:@"high_score"];
		[[NSUserDefaults standardUserDefaults] synchronize];
}

[kohjingyu]

- (void)viewDidLoad
{
       //Load data here
if ([[NSUserDefaults standardUserDefaults] integerForKey:@"high_score"]) {
		high_level_value=[[NSUserDefaults standardUserDefaults] integerForKey:@"high_score"];

	UIApplication *app = [UIApplication sharedApplication];
	[[NSNotificationCenter defaultCenter] addObserver:self
											 selector:@selector(applicationWillTerminate:)
												 name:UIApplicationWillTerminateNotification
											   object:app];
	
    [super viewDidLoad];
}

- (void)applicationWillTerminate:(NSNotification *)notification
{
       //Save data here
[[NSUserDefaults standardUserDefaults] setInteger:high_level_value forKey:@"high_score"];
		[[NSUserDefaults standardUserDefaults] synchronize];
}

There are a few errors in your code here.

Firstly, your if statement doesn't compare an integer to another integer.

Try this:

- (void)viewDidLoad
{
       //Load data here
high_level_value=[[NSUserDefaults standardUserDefaults] integerForKey:@"high_score"];

	UIApplication *app = [UIApplication sharedApplication];
	[[NSNotificationCenter defaultCenter] addObserver:self
											 selector:@selector(applicationWillTerminate:)
												 name:UIApplicationWillTerminateNotification
											   object:app];
	
    [super viewDidLoad];
}

Hope that helps.

[jbullfrog]

Originally Posted by kohjingyu

- (void)viewDidLoad
{
       //Load data here
if ([[NSUserDefaults standardUserDefaults] integerForKey:@"high_score"]) {
		high_level_value=[[NSUserDefaults standardUserDefaults] integerForKey:@"high_score"];

	UIApplication *app = [UIApplication sharedApplication];
	[[NSNotificationCenter defaultCenter] addObserver:self
											 selector:@selector(applicationWillTerminate:)
												 name:UIApplicationWillTerminateNotification
											   object:app];
	
    [super viewDidLoad];
}

- (void)applicationWillTerminate:(NSNotification *)notification
{
       //Save data here
[[NSUserDefaults standardUserDefaults] setInteger:high_level_value forKey:@"high_score"];
		[[NSUserDefaults standardUserDefaults] synchronize];
}

There are a few errors in your code here.

Firstly, your if statement doesn't compare an integer to another integer.

Try this:

- (void)viewDidLoad
{
       //Load data here
high_level_value=[[NSUserDefaults standardUserDefaults] integerForKey:@"high_score"];

	UIApplication *app = [UIApplication sharedApplication];
	[[NSNotificationCenter defaultCenter] addObserver:self
											 selector:@selector(applicationWillTerminate:)
												 name:UIApplicationWillTerminateNotification
											   object:app];
	
    [super viewDidLoad];
}

Hope that helps.

Just tried that and got nothing, no errors, or crashes, just not loading in the high level when i restart. Just a question, this should work in the sim right, its not something that must be on the device?

[jbullfrog]

I noticed that when i run it on the device and have console open, when the home button is pressed the last thing to register is

Debugger stopped.
Program exited with status value:0.

[jbullfrog]

Im stumped any thoughts as to why this isn't working?

[stolidimran]

Noticed a minor issue, replace this

//SAVE HIGH LEVEL
	
[[NSUserDefaults standardUserDefaults] setInteger:high_level_value forKey:@"high_score"];

With this

//SAVE HIGH LEVEL
	
[[NSUserDefaults standardUserDefaults] setInteger:[high_level_value intValue] forKey:@"high_score"];

Hope this helps!

[jbullfrog]

Originally Posted by stolidimran

Noticed a minor issue, replace this

//SAVE HIGH LEVEL
	
[[NSUserDefaults standardUserDefaults] setInteger:high_level_value forKey:@"high_score"];

With this

//SAVE HIGH LEVEL
	
[[NSUserDefaults standardUserDefaults] setInteger:[high_level_value intValue] forKey:@"high_score"];

Hope this helps!

When i do that i get this warning: invalid receiver type 'NSInteger'

Also and now im really stumped, when the player gets hit by the enemy, or when you collect the energy the value for the high level jumps from 0 to 264...

And this only seems to be happening in the simulator, not on the device.

[jbullfrog]

I somehow got rid of that 264...

And i noticed if I do this

[[NSUserDefaults standardUserDefaults] setInteger:[high_level.text intValue] forKey:@"high_score"];

Instead of this, as you mentioned stolidimran

[[NSUserDefaults standardUserDefaults] setInteger:high_level_value forKey:@"high_score"];

I dont get any warnings, but still not savint the high level value.

I am doing this in the game loop,

//COMPARE CURRENT LEVEL WITH HIGH LEVEL. 
		if([current_level.text intValue] > [high_level.text intValue]){
			
			high_level.text = current_level.text;
			
		}

And that is working fine, as you play the game its setting the high level to the current level if the current level is greater than the high level.

So im assuming that when the game is closed, the high level value should be saving with this.

	 - (void)applicationWillTerminate:(NSNotification *)notification
	{
		
		//Save data here
		[[NSUserDefaults standardUserDefaults] setInteger:high_level_value forKey:@"high_score"];
		[[NSUserDefaults standardUserDefaults] synchronize];
		NSLog(@"app quit, save high level");
	}

And loading with this when restarting

- (void)viewDidLoad {
	//Load data here
	high_level_value=[[NSUserDefaults standardUserDefaults] integerForKey:@"high_score"];
	NSLog(@"set high level");
	
	
	UIApplication *app = [UIApplication sharedApplication];
	[[NSNotificationCenter defaultCenter] addObserver:self selector:@selector(applicationWillTerminate:) name:UIApplicationWillTerminateNotification object:app];
	NSLog(@"check close high level");
 	
[super viewDidLoad];

}

but it just doesnt work..

[jbullfrog]

Ok, one small step for my app, one big step for me!

After thinking some more I solved my issue! I wasnt declaring the NSUserDefaults in the .h, so I set this in the ViewController.h

NSUserDefaults *prefs;
@property (nonatomic, retain) NSUserDefaults *prefs;

and in the ViewController.m

- (void)viewDidLoad {

	self.prefs = [NSUserDefaults standardUserDefaults];
	
	// Check to see what was stored in the user prefs, and update the label with that colour.
	if ([prefs stringForKey:@"high_score"]) {
		NSLog(@"The prefs is set.");
		high_level.text = [prefs stringForKey:@"high_score"];
	}

	high_level_value=[[NSUserDefaults standardUserDefaults] integerForKey:@"high_score"];
	NSLog(@"set high level");
	
	
	UIApplication *app = [UIApplication sharedApplication];
	[[NSNotificationCenter defaultCenter] addObserver:self selector:@selector(applicationWillTerminate:) name:UIApplicationWillTerminateNotification object:app];
	NSLog(@"check close high level");
 [super viewDidLoad];
}

	 - (void)applicationWillTerminate:(NSNotification *)notification
	{
		
		//Save data here
		[[NSUserDefaults standardUserDefaults] setInteger:[high_level.text intValue] forKey:@"high_score"];
		
		[[NSUserDefaults standardUserDefaults] synchronize];
		NSLog(@"app quit, save high level");
	}

Thanks for all the help