programmatically add animated UIImageView?

[jetwilson]

hi

I am adding a UIImageView programmatically into the view and filling it with an array of UImage objects and asking it to animate. However, nothing happens. Not even the first image displays in the view. I have previously been able to add one in using interface builder however that would prove impractical later on in my project.

This is my code:

aExplo.animationImages = [NSArray arrayWithObjects:
	 [UIImage imageNamed:@"RGB0001.png"],
	 [UIImage imageNamed:@"RGB0002.png"],
	 [UIImage imageNamed:@"RGB0003.png"],
	 [UIImage imageNamed:@"RGB0004.png"],
	 [UIImage imageNamed:@"RGB0005.png"],
	 [UIImage imageNamed:@"RGB0006.png"],
	 [UIImage imageNamed:@"RGB0007.png"],
	 [UIImage imageNamed:@"RGB0008.png"],
	 [UIImage imageNamed:@"RGB0009.png"],
	 [UIImage imageNamed:@"RGB0010.png"],
	 [UIImage imageNamed:@"RGB0011.png"],
	 [UIImage imageNamed:@"RGB0012.png"],
	 [UIImage imageNamed:@"RGB0013.png"],
	 [UIImage imageNamed:@"RGB0014.png"],
	 [UIImage imageNamed:@"RGB0015.png"]];
aExplo.animationRepeatCount = 1;
aExplo.animationDuration = 1;
aExplo.center = CGPointMake(100, 100);
[aExplo startAnimating];
[self.view addSubview:aExplo];

I set an @property (nonatomic, retain) and an @synthesize for the aExplo UIImageView. Is there anything im missing?

Thanks

Jetwilson

[kelvinkao]

Did you set the frame for the UIImageView to display in?

[jetwilson]

Originally Posted by kelvinkao

Did you set the frame for the UIImageView to display in?

err... no.

I couldn't see anything in the documentation about setting a frame! What do I need to do to set a frame? do I need to call initWithFrame:?

EDIT: okay, i tried this code before I add images to the array to create a frame:

UIImage *image = [UIImage imageNamed:@"RGB0001.png"];
CGRect frame = CGRectMake(0, 0, image.size.width, image.size.height);
aExplo = [[UIImageView alloc] initWithFrame:frame];

One small problem - the program now crashes. Am I setting the frame correctly?

jetwilson

[imapps]

the frame looks fine. Where does your app crash? What does the debugger say?

[jetwilson]

Originally Posted by imapps

the frame looks fine. Where does your app crash? What does the debugger say?

It crashes the next line after the frame code - the one where I create an array of images for the animationImages:

aExplo.animationImages = [NSArray arrayWithObjects:
	 [UIImage imageNamed:@"RGB0001.png"],
	 [UIImage imageNamed:@"RGB0002.png"],
	 [UIImage imageNamed:@"RGB0003.png"],
	 [UIImage imageNamed:@"RGB0004.png"],
	 [UIImage imageNamed:@"RGB0005.png"],
	 [UIImage imageNamed:@"RGB0006.png"],
	 [UIImage imageNamed:@"RGB0007.png"],
	 [UIImage imageNamed:@"RGB0008.png"],
	 [UIImage imageNamed:@"RGB0009.png"],
	 [UIImage imageNamed:@"RGB0010.png"],
	 [UIImage imageNamed:@"RGB0011.png"],
	 [UIImage imageNamed:@"RGB0012.png"],
	 [UIImage imageNamed:@"RGB0013.png"],
	 [UIImage imageNamed:@"RGB0014.png"],
	 [UIImage imageNamed:@"RGB0015.png"]];

The last thing it says in the debugger window is objc_msgsend if that helps.

thanks

jetwilson

[imapps]

You're missing a nil after the last object in array. arrayWithObjects: requires a comma separated array items ending with nil like this:

aExplo.animationImages = [NSArray arrayWithObjects:
	 [UIImage imageNamed:@"RGB0001.png"],
	 [UIImage imageNamed:@"RGB0002.png"],
	 [UIImage imageNamed:@"RGB0003.png"],
	 [UIImage imageNamed:@"RGB0004.png"],
	 [UIImage imageNamed:@"RGB0005.png"],
	 [UIImage imageNamed:@"RGB0006.png"],
	 [UIImage imageNamed:@"RGB0007.png"],
	 [UIImage imageNamed:@"RGB0008.png"],
	 [UIImage imageNamed:@"RGB0009.png"],
	 [UIImage imageNamed:@"RGB0010.png"],
	 [UIImage imageNamed:@"RGB0011.png"],
	 [UIImage imageNamed:@"RGB0012.png"],
	 [UIImage imageNamed:@"RGB0013.png"],
	 [UIImage imageNamed:@"RGB0014.png"],
	 [UIImage imageNamed:@"RGB0015.png"],
         nil];

[jetwilson]

Originally Posted by imapps

You're missing a nil after the last object in array. arrayWithObjects: requires a comma separated array items ending with nil like this:

aExplo.animationImages = [NSArray arrayWithObjects:
	 [UIImage imageNamed:@"RGB0001.png"],
	 [UIImage imageNamed:@"RGB0002.png"],
	 [UIImage imageNamed:@"RGB0003.png"],
	 [UIImage imageNamed:@"RGB0004.png"],
	 [UIImage imageNamed:@"RGB0005.png"],
	 [UIImage imageNamed:@"RGB0006.png"],
	 [UIImage imageNamed:@"RGB0007.png"],
	 [UIImage imageNamed:@"RGB0008.png"],
	 [UIImage imageNamed:@"RGB0009.png"],
	 [UIImage imageNamed:@"RGB0010.png"],
	 [UIImage imageNamed:@"RGB0011.png"],
	 [UIImage imageNamed:@"RGB0012.png"],
	 [UIImage imageNamed:@"RGB0013.png"],
	 [UIImage imageNamed:@"RGB0014.png"],
	 [UIImage imageNamed:@"RGB0015.png"],
         nil];

Thank you! It worked perfectly! I cant believe I missed something so simple!

Jetwilson

[imapps]

np
Glad I could help.

[JeromeC]

meh, I come too late!
Anyhow I just finished a tutorial on just that topic: Link

[jetwilson]

The previous problem was me just starting at the basics, once I had that sorted I thought I would expand and make this code more reusable. But yet another block has reared its ugly head.

I thought, to make the animation code more reusable and efficient I would create a UIView object and then create instances of that class to use within the main view.

This is the code within the explosionView.m UIView object file:

- (id)init {
	UIImage *image = [UIImage imageNamed:@"RGB0001.png"];
	CGRect frame = CGRectMake(0, 0, image.size.width, image.size.height);
	aExplosionView = [[UIImageView alloc] initWithFrame:frame];
	[image release];
	
	self.opaque = NO;
	aExplosionView.animationImages = [NSArray arrayWithObjects:
							[UIImage imageNamed:@"RGB0001.png"],
							[UIImage imageNamed:@"RGB0002.png"],
							[UIImage imageNamed:@"RGB0003.png"],
							[UIImage imageNamed:@"RGB0004.png"],
							[UIImage imageNamed:@"RGB0005.png"],
							[UIImage imageNamed:@"RGB0006.png"],
							[UIImage imageNamed:@"RGB0007.png"],
							[UIImage imageNamed:@"RGB0008.png"],
							[UIImage imageNamed:@"RGB0009.png"],
							[UIImage imageNamed:@"RGB0010.png"],
							[UIImage imageNamed:@"RGB0011.png"],
							[UIImage imageNamed:@"RGB0012.png"],
							[UIImage imageNamed:@"RGB0013.png"],
							[UIImage imageNamed:@"RGB0014.png"],
							[UIImage imageNamed:@"RGB0015.png"],
							nil];
		
	aExplosionView.animationRepeatCount = 1;
	aExplosionView.animationDuration = 1;
	aExplosionView.center = CGPointMake(0, 0);
	[aExplosionView startAnimating];
	
	return self;
}

pretty much exactly the same as before.

and in my mainViewController.m I do this to create an instance of the explosionView class in viewDidLoad:

UIImage *image = [UIImage imageNamed:@"RGB0001.png"];
CGRect frame = CGRectMake(0, 0, image.size.width, image.size.height);
explosionView *explo = [[explosionView alloc] initWithFrame:frame];
[image release];explo.center = CGPointMake(100, 100);
[self.view addSubview:explo];

I have done this before with UIImages for non-animation images - but when I tried with this animating UIImageView, a black square where my animation should be displayed is displayed. No crash, no nothing. Just a black square. Not terribly useful!

Anyone know what's happening?

Thanks

Jetwilson

[d4devil]

Hi i have used the coding technique you mentioned above, My image has started animation. But it is not well placed at the location i mentioned

This is the code i am using
UIImage *myBalloonImage=[UIImage imageNamed:@"ABalloon.png"];
UIImageView *myBalloonAnimatedView = [[UIImageView alloc] initWithImage:myBalloonImage];

CGRect frameBalloon = CGRectMake(60, 20,myBalloonImage.size.height, myBalloonImage.size.width);
myBalloonAnimatedView = [[UIImageView alloc] initWithFrame:frameBalloon];
[myBalloonImage release];
NSArray *myBalloonImages = [NSArray arrayWithObjects:
[UIImage imageNamed:@"ABalloon.png"],
[UIImage imageNamed:@"CBalloon.png"],
[UIImage imageNamed:@"EBalloon.png"],
nil];

myBalloonAnimatedView.animationImages = myBalloonImages;
myBalloonAnimatedView.animationDuration = 2.0;
myBalloonAnimatedView.animationRepeatCount = 0;
[myBalloonAnimatedView startAnimating];
myBalloonAnimatedView.center=CGPointMake(160, 160);
[self.view addSubview:myBalloonAnimatedView];
[myBalloonAnimatedView release];

Now kindly tell me in hurry where i am doing mistake. According to me , There is some problem i am facing in making frames.