Memory Leak in Flipsideviewcontroller.m, Please help

[iphoneguy777]

Hello:

I'm trying to get rid of a leak in my flipsideviewcontroller.m file and I'm not sure where I'm going wrong. I have two releases for my retains but when I run "leaks" in instruments in points me to this file and that UIImages are leaking. Any help analyzing this info would be greatly appreciated.

// random from 11 images "girl0_9"
NSString *fileName = [NSString stringWithFormat:@"girl%d_%d", gCategory, rand];

// NSLog(@"load image %@", fileName);

// UIImage *img = [[UIImage imageWithContentsOfFile: [[NSBundle mainBundle] pathForResource:fileName ofType:@"jpg"]] retain];
UIImage *img = [UIImage imageWithContentsOfFile: [[NSBundle mainBundle] pathForResource:fileName ofType:@"jpg"]];
// [fileName release];
// UIImage *img = [[UIImage imageWithContentsOfFile: [[NSBundle mainBundle] pathForResource:@"menu_bg" ofType:@"png"]] retain];

[bgImage setImage:img];
//[img release];

Thanks,
Iphoneguy777

[BrianSlick]

Just a tip: it's probably best to remove commented lines from your sample code before posting to avoid confusion.

I don't see anything that would be a leak, per se. You are creating autoreleased objects, so those may be sticking around for a bit. Is Leaks saying that you have a leak, or are you merely investigating and observing that the images still exist longer than you expect?

When in doubt, avoid autoreleased objects. Ex:

NSString *fileName = [[NSString alloc] initWithFormat:@"girl%d_%d", gCategory, rand];

UIImage *img = [[UIImage alloc] initWithContentsOfFile: [[NSBundle mainBundle] pathForResource:fileName ofType:@"jpg"]];

[bgImage setImage:img];

[img release], img = nil;
[fileName release], filename = nil;

I don't think that Leaks will report autoreleased items as "leaks", so if you are getting the little leak spike in your graph, then the issue is probably somewhere else.

[iphoneguy777]

You made my day. Got your app, I'm excited to try it out. Thanks a lot.

Originally Posted by BrianSlick

Just a tip: it's probably best to remove commented lines from your sample code before posting to avoid confusion.

I don't see anything that would be a leak, per se. You are creating autoreleased objects, so those may be sticking around for a bit. Is Leaks saying that you have a leak, or are you merely investigating and observing that the images still exist longer than you expect?

When in doubt, avoid autoreleased objects. Ex:

NSString *fileName = [[NSString alloc] initWithFormat:@"girl%d_%d", gCategory, rand];

UIImage *img = [[UIImage alloc] initWithContentsOfFile: [[NSBundle mainBundle] pathForResource:fileName ofType:@"jpg"]];

[bgImage setImage:img];

[img release], img = nil;
[fileName release], filename = nil;

I don't think that Leaks will report autoreleased items as "leaks", so if you are getting the little leak spike in your graph, then the issue is probably somewhere else.