iPhone random number game error

cocoa · 03-30-2009, 04:39 AM

This is some code which is supposed to program a simple iPhone application which generates a random number, the user must guess the correct number and the program will give it the appropriate feedback. The main code itself seems to compile succesfully in C++ (we changed the file extension to main.mm because of this) however, we only started working on the GUI after we had finished the main code.
The only error we have received is the one indicated in red text regarding the randomly generated number in the ViewController.h file. Any suggestions as to how to solve this problem? Is there anything else which would prohibit the code from functioning seamlessy together in a working iPhone application?
We are honestly beginners and would appreciate any help whatsoever.

main.mm:

#import <UIKit/UIKit.h>
#include<iostream>
#include<cstdlib>
#include<ctime>

using namespace std;
int main()
{
//Seed random number generator
srand(time(0));
//Creates the random number between 1 and 10
int theNumber = rand() % 10 + 1;
int guess;
//Guessing loop
int tries;
while (guess != theNumber)
{
cout<<"Please guess the number!: ";
cin>>guess;
++tries;
if (guess > theNumber)
cout<<"Too high,Guess again:"<< endl << endl;
if (guess < theNumber)
cout << "Too low,Guess again: "<< endl << endl;
}

cout << endl << "Congrats!! You got it" //<<tries<< "guesses."
<< endl;
return 0;
}

RandomnumberViewController.m:

#import "Randomnumber6ViewController.h"

@implementation Randomnumber6ViewController

@synthesize txtNumber,lblPleaseguess;

-(IBAction) updateText

id) sender {
NSString *text;
if([srand(time(0)] == int guess) {
text = @"Congrats!! You got it";
}
else
{
if (guess > theNumber) text = [[NSString alloc] initWithFormat:@"Too high,Guess again:"
if (guess < theNumber) text = [[NSString alloc] initWithFormat:@"Too low,Guess again:"
}

lblPleaseguess.text = text;

[text release];
}

- (void)didReceiveMemoryWarning {
[super didReceiveMemoryWarning]; // Releases the view if it doesn't have a superview
// Release anything that's not essential, such as cached data
}

- (void)dealloc {
[super dealloc];
}

@end

RandomnumberViewController.h:

#import <UIKit/UIKit.h>

@interface Randomnumber6ViewController : UIViewController {
IBOutlet UITextField *txtNumber;
IBOutlet UILabel *lblPleaseguess;

}

@property(nonatomic,retain) IBOutlet UITextField *txtNumber;
@property(nonatomic,retain) IBOutlet UILabel *lblPleaseguess;
- (IBAction) updateText

id) sender;

@end

bfk · 04-01-2009, 12:09 AM

The line giving you trouble makes no sense.
You seem to be declaring a variable named guess inside an if conditional test, even if that worked the value would be uninitialised and could be anything. You're also comparing the uninitialised value for guess with the void return from srand().

You should be comparing the randomly generated number with what the user entered, but that's not what's happening here.

I assume the user is entering a number in a text field.

You could use a delegate for the NSTextField and put your checking code in then UITextFieldTextDidChangeNotification notification.
Then notification.object.text.intValue will give you what the user entered, if it matches the random number you generated and stored somewhere then tell the user he's very clever and generate the next random number and start again.

I also don't see any code to generate the random numbers. You also need an ivar to store the correct answer so that you can test against the user's input.

Hope this helps,
Brian

smasher · 04-01-2009, 12:25 AM

Cocoa, You're probably going to have to start with the cocoa "hello world" examples and, once oyu understand it, adapt it to what you need.

Your program as written won't work because:
(1)cout and cin don't work on the phone
(2)you can't use a while loop to wait for input in an event-driven system
(3)You need to do your work in the viewController, not in main()

This particular line is busted in two ways:

Code:

if([srand(time(0)] == int guess) {

(4)the srand function seeds the random number generator; it doesn't produce a number.
(5)"int guess" would declare a new "guess" variable. You want to compare to what the user chose instead.

You probably want to compare your stored random number to [sender.text intValue]

There's no shortcut for learning this stuff.

shonday · 04-01-2009, 02:18 AM

It seems like you took your C++ code and tried to transplant it to Objective C. That's a really bad way to write a program, let alone learn the language. You should start from scratch...you'll pick it up pretty quickly because of your knowledge of C++.

pmaxjenkins · 04-22-2009, 07:52 AM

This is the way I have been generating a random number for a game I'm working on. The code blow creates a random number between 1 and 7. Change the 7 to what ever number you like.

randomNo = (arc4random() %7);

will.ray · 04-22-2009, 10:06 AM

smasher is right... you basically wrote this program as a console app, so it is kind of a square peg/round whole situation from the beginning....

in addition the line in red is wrong. int guess should already be declared and assigned to something before you use it in an 'if' statement.

Naughty_Ottsel · 04-22-2009, 01:48 PM

Like they've all said, this is a C++ console app, trust me I've done it and extended it, if you want any help I'll happily do so, you might want to check out my app - iGuess, it's essentially the best guessing app on the app store so far, and is about to get better!