ABMultiValueRef memory leak

[ifonenewbie]

I'm trying to access just the email ID's of contacts and since there could be multiple emails, I'm using ABMultiValueRef


Here's my code:


- (BOOL)peoplePickerNavigationController: (ABPeoplePickerNavigationController *)peoplePicker shouldContinueAfterSelectingPersonABRecordRef)pe rson
propertyABPropertyID)property identifierABMultiValueIdentifier)identifier{


ABMultiValueRef emails = ABRecordCopyValue(person, property);
CFStringRef emailID = ABMultiValueCopyValueAtIndex(emails, identifier);

[self AddEmployeeEmailNSString*)emailID ];

[self dismissModalViewControllerAnimated:YES];

return NO;
}


If I run this code through Leaks, it complains about a memory leak which i could resolve by '[emails release]', but this gives me a compiler warning. I've seen some posts about certain leaks happening on the simulator but not on the device. Could this be one of them??

Any suggestions ??

[wuf810]

Originally Posted by ifonenewbie

I've seen some posts about certain leaks happening on the simulator but not on the device. Could this be one of them??

Any suggestions ??

If definitely could be. Try running launching and running your app with instruments on the iPhone itself. If the leak occurs then at least you know it is not just a simulator issue.

Good luck.

M

[ifonenewbie]

OK, it leaks on the device too.

Is there another way to copy the email when there are multiple emails? I tried using

NSString* emails = (NSString*)ABRecordCopyValue(person, KABPersonEmailProperty);

but that isn't working either.

If I try this, I get a message saying the 'variable isn't a CFString at this time'

CFString emails = ABRecordCopyValue(person,property);

Does anyone have a working sample which doesn't leak

[jsonli]

I'm not familiar with the CF stuff so I can't help you off the bat, but look up what ABRecordCopyValue is actually doing. Hold alt and double click it.

NSString and CFString shouldn't be interchangeable.

The variable emails doesn't look to be derived from NSObject so you should not be calling release on it if I'm correct.

In C you use malloc to allocate memory, and free to free it. Perhaps you should use free?

[BSDimwit]

CFStringRef email, emailLabel;

ABMutableMultiValueRef multi = ABRecordCopyValue(person, kABPersonEmailProperty);
NSMutableDictionary *myEmailDict = [NSMutableDictionary dictionaryWithCapacity:ABMultiValueGetCount(multi)];
for (CFIndex i = 0; i < ABMultiValueGetCount(multi); i++) { 
	
	emailLabel = ABAddressBookCopyLocalizedLabel(ABMultiValueCopyLabelAtIndex(multi, i));
	email = ABMultiValueCopyValueAtIndex(multi, i); 
	[myEmailDict setObject:(NSString*)email forKey:(NSString*)emailLabel];
	CFRelease(email);
	CFRelease(emailLabel);
	
} 

if ([myEmailDict objectForKey:@"work"] != nil) {
	[self AddEmployeeEmail:[myEmailDict objectForKey:@"work"]];
}

Here is how I roughly do it in my code. I put the results in a dictionary that which ups the retain count by 1 then I release the address and the label... Let me know how this work out for you.