First, you cant have multiple definitions of the same method. OnButtonClick is defined twice, you need to combine the two methods. I'll get to that later.
fileContents is an NSString and needs to be declared in your Header file.
Code:
NSString *fileContents;
or if you dont plan on using it in more than one method you dont have to, just add NSString *fileContents = blah blah blah...
You didn't quite finish. You renamed categoryDic, "elevatorJokes" but didn't change it in [categoryDic valueForKey...
Same with your NSMutableArray eleJokes. [items count]; should be [eleJokes count];
[sillyJokes objectAtIndex:randomNumber]; needs to be [eleJokes objectAtIndex:randomNumber];
Now, copy every inside your second OnButtonClick. Paste it inside the first one.
Delete the displayString line.
And edit [appDelegate setModelData:displayString]; to
Code:
[appDelegate setModelData:joke];
I think that about takes care of it...
Also, you will want to give your variables more meaningful names. Such as elevatorJokesDict or eleJokesMutArray. That way in the future you actually know what they are.